Upgrade kube
to 0.98 and migrate event Recorder
#116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for kube-rs/kube#1655
Migration
It is recommended to now create the event
Recorder
globally (and not inside the reconciler) because it caches recent events to not over-publish.This can generally be done by stuffing it inside the
Context
you pass to theController
and then give it an extra object reference (which you previously used to construct theRecorder
) when publishing events.(In our case that's made
Context
creation async, but that's because we use an async mutex around it.)Showcasing
using
cargo run
(and installing the crd)we can get repeat events using
k apply -f yaml/instance-samuel.yaml
and thenk edit doc samuel
to togglehide
on and off.and it aggregates it correctly:
Note the
(x2 over 75s)
part which is kubectl displayingEventSeries
.