-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showcase predicate filters with timestamp in status #50
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: Eirik A <[email protected]>
Signed-off-by: clux <[email protected]>
Hi @clux. Any plans on making this API stable? (maybe I should write to the issue instead...) |
Hey, that would be a kube issue. I think this is probably close. But want to have a think w.r.t. more complicated filters, because while they are useful right now, there are some more complicated filters we could do that could follow the same pattern. I don't think that should need to change the existing predicates though. I'll open an issue in kube over the weekend probably, otherwise feel free to raise it. EDIT: thought about it, seems completely reasonable. PR in kube-rs/kube#1578 |
Signed-off-by: Eirik A <[email protected]>
Signed-off-by: clux <[email protected]>
Updated this PR against current. Predicates are stabilised in 0.96, but the |
This was impossible before kube 0.81.
Having a random timestamp in a status field would cause the controller to spin constantly as it kept triggering itself.
Now with predicates from kube-rs/kube#911 it is possible to avoid this and have timestamps (say) in status objects.
Probably not going to merge this as these are unstable interfaces, just showcasing it here atm.