Fixup watcher docs, and watchlist doc examples #1284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of missing references in doc builds because we don't have warnings as errors on doc builds. Maybe we should.
Removed the
namespace_reflector
example because it's a slowly changing thing to watch, and instead added a way to opt-in toWATCHLIST=1
inpod_
andnode_
watchers.Was trying to allow this on
event_watcher
also but apparently events onk3s
do not support sendInitialEvents on 1.27 yet so left it out there. While in the area though, i updatedevent_watcher
to use the newEvent
type (rather than the legacy core one) to make the example better.EDIT: follow-up on param serializer might also be needed but doing that separaetly #1281 (comment) - am ultimately not changing the logic anywhere here, just applying clippy suggestions