Revamp event and log examples to allow more parameters #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have `clap` in the dependency tree so thought it would be useful to show how to do some more things in the kubectl style. - `event_watcher` now has an optional flag to limit to one object (ala `kubectl events --for`) - `log_stream` now supports the basic flags that `kubectl logs` do - `kubectl` helpers for formatting duration are aligned across examples Signed-off-by: clux <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
==========================================
- Coverage 72.27% 72.19% -0.09%
==========================================
Files 75 75
Lines 6259 6258 -1
==========================================
- Hits 4524 4518 -6
- Misses 1735 1740 +5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have
clapin the dependency tree so thought it would be useful to show how to do some more things in thekubectlstyle.event_watchernow has an optional flag to limit to one object (alakubectl events --for)log_streamnow supports the basic flags thatkubectl logsdokubectlhelpers for formatting duration are aligned across examples(Clippy issues warned about here comes from 1.72 and are fixed in #1288)