Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade darling and syn and rename #[kube(struct)] #1307

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Upgrade darling and syn and rename #[kube(struct)] #1307

merged 4 commits into from
Oct 12, 2023

Conversation

clux
Copy link
Member

@clux clux commented Oct 10, 2023

Somewhere from this upgrade is a breaking change that makes it illegal to use struct as an attribute name.

Users will see this error if using #[kube(struct)]:

  --> examples/crd_derive.rs:18:5
   |
18 |     struct = "FooCrd",
   |     ^^^^^^

Have worked around this by renaming this attribute name to something less keywordy:

-#[kube(struct = FooCrd)]
+#[kube(root = FooCrd)]

Will point this out in the release notes if it is accepted.

@clux clux mentioned this pull request Oct 10, 2023
6 tasks
@clux clux added the changelog-change changelog change category for prs label Oct 10, 2023
@clux clux added this to the 0.87.0 milestone Oct 10, 2023
@clux clux changed the title Upgrade darling and syn Upgrade darling and syn and rename #[kube(struct)] Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1307 (7f1a577) into main (fba2b9d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1307   +/-   ##
=====================================
  Coverage   72.4%   72.4%           
=====================================
  Files         75      75           
  Lines       6343    6343           
=====================================
  Hits        4586    4586           
  Misses      1757    1757           
Files Coverage Δ
kube-derive/src/custom_resource.rs 13.8% <ø> (ø)
kube-derive/src/lib.rs 0.0% <ø> (ø)

@clux clux marked this pull request as ready for review October 10, 2023 20:34
@clux clux requested review from kazk and nightkr October 10, 2023 20:34
@clux clux added the dependencies upgrades to dependencies label Oct 10, 2023
@nightkr
Copy link
Member

nightkr commented Oct 12, 2023

How about crd or object? resource_struct maybe...

@clux
Copy link
Member Author

clux commented Oct 12, 2023

How about crd or object? resource_struct maybe...

All of these feel too overloaded to me. I kind of like something with generate or root (root_struct?) because we refer to the generated struct, generated root type a lot in https://docs.rs/kube/latest/kube/derive.CustomResource.html

@nightkr
Copy link
Member

nightkr commented Oct 12, 2023

I like root.

@clux clux linked an issue Oct 12, 2023 that may be closed by this pull request
6 tasks
@clux clux merged commit c3fbe25 into main Oct 12, 2023
18 checks passed
@clux clux deleted the bump-syn branch October 12, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-change changelog change category for prs dependencies upgrades to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency Bumps Q2 2023
3 participants