Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed KUBERNETES_EXEC_INFO environment variable passed to auth plugins #1320

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

Razz4780
Copy link
Contributor

Closes #1318

Motivation

Custom authentication plugin fails when used with this client. Authentication plugins expect KUBERNETES_EXEC_INFO environment variable, which should contain a serialized ExecCredential object. Field kind of this object should contain ExecCredential string.

Solution

Setting kind to ExecCredential before serialization.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #1320 (f6a6c69) into main (c3fbe25) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 0.0%.

❗ Current head f6a6c69 differs from pull request most recent head 1872d6f. Consider uploading reports for the commit 1872d6f to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1320   +/-   ##
=====================================
  Coverage   72.4%   72.4%           
=====================================
  Files         75      75           
  Lines       6343    6343           
=====================================
  Hits        4587    4587           
  Misses      1756    1756           
Files Coverage Δ
kube-client/src/client/auth/mod.rs 50.5% <0.0%> (ø)

@clux clux added this to the 0.87.0 milestone Oct 25, 2023
@clux clux added the changelog-fix changelog fix category for prs label Oct 25, 2023
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, lol. yeah, lgtm 👍

@clux clux enabled auto-merge (squash) October 25, 2023 22:55
@clux clux merged commit 9c81f1f into kube-rs:main Oct 25, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication fails with custom kubectl plugin
2 participants