Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tarpaulin bump and simplify config setup #1460

Closed
wants to merge 2 commits into from
Closed

tarpaulin bump and simplify config setup #1460

wants to merge 2 commits into from

Conversation

clux
Copy link
Member

@clux clux commented Apr 3, 2024

experiment for #1144 where we can compare against https://app.codecov.io/gh/kube-rs/kube/tree/main/
config ref

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.4%. Comparing base (5dce83b) to head (c4b0cb9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1460     +/-   ##
=======================================
- Coverage   72.1%   67.4%   -4.6%     
=======================================
  Files         78      71      -7     
  Lines       6592    5071   -1521     
=======================================
- Hits        4747    3416   -1331     
+ Misses      1845    1655    -190     

see 37 files with indirect coverage changes

@clux clux mentioned this pull request Apr 3, 2024
4 tasks
@tyrone-wu
Copy link
Contributor

So I forked and modified tarpaulin to address this issue, and it definitely looks like the #[tokio::test] it's where the missing coverage went. Now, I'm actually getting 74%. I'll try to link it here.

@tyrone-wu
Copy link
Contributor

tyrone-wu commented Apr 4, 2024

Here's the report (was manually uploaded to codecov) of the new coverage.
https://app.codecov.io/gh/tyrone-wu/kube

@clux
Copy link
Member Author

clux commented Apr 5, 2024

Ah, amazing. That looks much better. I see you you have an upstream PR as well 👍

@clux
Copy link
Member Author

clux commented Apr 12, 2024

closed by #1466

@clux clux closed this Apr 12, 2024
@clux clux deleted the cov-tweak branch April 12, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants