chore(deps): replace backoff with backon #1653
Open
+235
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the `backoff` dependency with `backon`. The former one is no longer maintained and is also pulling the `instant` crate, which has been marked as unmaintained by RUSTSEC. Prior to this commit the public API of kube-rs exposed a trait defined by the `backoff` crate. This commits introduces a new trait defined by kube-rs, which wraps the `backon` trait. Fixes kube-rs#1635 Signed-off-by: Flavio Castelli <[email protected]>
flavio
force-pushed
the
replace-instant-with-backon
branch
from
53cc42e
to
a7d6e70
Compare
|
About the |
|
Also, the tarpaulin failure doesn't seem related with this PR |
|
Yeah.. ran into tarpaulin issues on my end too. Need to go figure out what's happening there. FWIW I took a stab at this as well (#1652) since I didn't realize you had picked it up too. |
|
@nightkr: ouch, I didn't notice you had just submitted a similar PR 😓 |
|
Didn't realize you had actually picked up the issue 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
backoffcrate is no longer maintained and it's pulling theinstantwhich is also marked as unmaintained by RUSTSEC.This PR fixes #1635
Solution
Replace the
backoffdependency withbackon. The former one is no longer maintained and is also pulling theinstantcrate, which has been marked as unmaintained by RUSTSEC.Prior to this commit the public API of kube-rs exposed a trait defined by the
backoffcrate. This commits introduces a new trait defined by kube-rs, which wraps thebackontrait.I also had to introduce this new trait because the
backon::Backofftrait doesn't have aresetmethod. kubers makes use of this method, hence the "trick" of defining our own trait solves this challenge. If you don't like this approach, I can try to go upstream tobackonand propose the extension of their trait to include theresetmethod.