-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle pod deletion in kubearmor controller #1952
Open
Aryan-sharma11
wants to merge
11
commits into
kubearmor:main
Choose a base branch
from
Aryan-sharma11:fix-pod-deletion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+369
−266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aryan-sharma11
force-pushed
the
fix-pod-deletion
branch
2 times, most recently
from
February 3, 2025 05:45
ae3d494
to
ac30593
Compare
Aryan-sharma11
force-pushed
the
fix-pod-deletion
branch
from
February 4, 2025 09:41
32c2385
to
59920a0
Compare
Signed-off-by: Aryan-sharma11 <[email protected]>
Signed-off-by: Aryan-sharma11 <[email protected]>
Signed-off-by: Aryan-sharma11 <[email protected]>
Signed-off-by: Aryan-sharma11 <[email protected]>
Signed-off-by: Aryan-sharma11 <[email protected]>
Signed-off-by: Aryan-sharma11 <[email protected]>
Signed-off-by: Aryan-sharma11 <[email protected]>
Signed-off-by: Aryan-sharma11 <[email protected]>
Signed-off-by: Aryan-sharma11 <[email protected]>
Aryan-sharma11
force-pushed
the
fix-pod-deletion
branch
8 times, most recently
from
February 5, 2025 10:05
adc8545
to
03e8a60
Compare
Signed-off-by: Aryan-sharma11 <[email protected]>
Aryan-sharma11
force-pushed
the
fix-pod-deletion
branch
from
February 5, 2025 10:16
03e8a60
to
d325cfd
Compare
Aryan-sharma11
changed the title
fix: [WIP] handle pod deletion in kubearmor controller
fix: handle pod deletion in kubearmor controller
Feb 5, 2025
Aryan-sharma11
force-pushed
the
fix-pod-deletion
branch
5 times, most recently
from
February 6, 2025 04:01
65bf9a2
to
ed093ba
Compare
Signed-off-by: Aryan-sharma11 <[email protected]>
Aryan-sharma11
force-pushed
the
fix-pod-deletion
branch
from
February 6, 2025 04:58
ed093ba
to
253ace0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #1935
Does this PR introduce a breaking change?
No
Changes included
1) Handle pod restarts
"kubearmor.kubernetes.io/restartedAt"
to trigger a rolling restart for all the pods.2) NodeWatcher
3) Pod Mutation
This will help us in optimising our annotation handling for hybrid clusters (AppArmor + BPFLSM enforcer) therefore improving overall controller performance
ref