-
Notifications
You must be signed in to change notification settings - Fork 107
Remove references to ContainerStats pipeline #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -1,5 +1,8 @@ | |||
# ContainerStats Pipeline | |||
|
|||
> [!CAUTION] | |||
> The ContainerStats pipeline is deprecated. This page should no longer be consulted. Kubecost APIs no longer use this pipeline's data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"deprecated" ≠ "removed". Is this deprecated (currently still works but is signaled for later removal) or removed (currently does not work)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, sorry! I keep conflating those terms.
In this case ContainerStats "works", but its resulting output is no longer being used by the Aggregator. I think this qualifies as being deprecated, but it may just be safer to say that this feature is being removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have keyed in on this earlier (sorry), but if we remove the page then we can't also show this cautionary note. For IBM's docs (where this will be translated), we can't not have a page be referenced in the site map but also still served. So can we just strike mentions elsewhere as you've indicated here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! I've addressed your feedback in a commit. I'm now using the term "Removed". And I'm keeping this doc in the SUMMARY.md
file.
Related Issue
containerStatsEnabled
from values files cost-analyzer-helm-chart#3683Proposed Changes
Remove references to ContainerStats, as its data is no longer required in the product.