feat: enable data caching cross jobs #263
Conversation
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
+ Coverage 29.43% 30.07% +0.64%
==========================================
Files 89 89
Lines 6193 6260 +67
==========================================
+ Hits 1823 1883 +60
- Misses 4108 4115 +7
Partials 262 262
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@zjchenn hi zjchenn, thanks for your contribution! you may design & implement unit testing in next stage of work. |
| UsedBy []string `json:"usedBy,omitempty"` | ||
|
|
||
| // UsedNum equals to the size of UsedBy array | ||
| UsedNum int `json:"usedNum,omitempty"` |
There was a problem hiding this comment.
since UsedNum equals to the size of UsedBy array, why we need maintain another filed?
| UsedNum int `json:"usedNum,omitempty"` | ||
|
|
||
| // IdleTime means how long cacheBackend is not currently in use | ||
| IdleTime string `json:"idleTime,omitempty"` |
There was a problem hiding this comment.
re-type string -> time.Duration may be better
zjchenn
changed the title
…e reused Signed-off-by: Zhijun Chen <[email protected]>
Signed-off-by: Zhijun Chen <[email protected]>
Signed-off-by: Zhijun Chen <[email protected]>
Signed-off-by: Zhijun Chen <[email protected]>
zjchenn
force-pushed
the
feat/cache-reuse
branch
from
4070595 to
7f7769e
Compare
Signed-off-by: Zhijun Chen <[email protected]>
Signed-off-by: Zhijun Chen <[email protected]>
|
/cc @SimonCqk |
| @@ -17,6 +17,8 @@ limitations under the License. | |||
| package v1alpha1 | |||
There was a problem hiding this comment.
I was thinking the naming between CacheBackend and Dataset, CacheBackend couples with caching system semantics but Dataset only describes a set of data with higher-level abstraction, cache can be an add-on feature over dataset.
There was a problem hiding this comment.
Hi Simon, you are right. Maybe we can merge this PR first? I will refactor CacheBackend to Dataset in another PR.
|
/LGTM |
Signed-off-by: Zhijun Chen [email protected]
Ⅰ. Describe what this PR does
This PR decouples cacheBackend from jobs and makes cacheBackend can be reused in different jobs.
II. Does this pull request fix one issue?
#252
III. Special notes for reviewers if any.
In progress, update doc & unit testing later.