Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): turn off GKE metadata by default #11321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ui): turn off GKE metadata by default #11321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/server/configs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export function loadConfigs(argv: string[], env: ProcessEnv): UIConfigs {
/** The main container name of a pod where logs are retrieved */
POD_LOG_CONTAINER_NAME = 'main',
/** Disables GKE metadata endpoint. */
DISABLE_GKE_METADATA = 'false',
DISABLE_GKE_METADATA = 'true',
/** Enable authorization checks for multi user mode. */
ENABLE_AUTHZ = 'false',
/** Deployment type. */
Expand Down
13 changes: 13 additions & 0 deletions manifests/kustomize/env/gcp/gcp-configurations-patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,16 @@ spec:
configMapKeyRef:
name: pipeline-install-config
key: gcsProjectId
---
apiVersion: apps/v1
kind: Deployment
metadata:
name: ml-pipeline-ui
spec:
template:
spec:
containers:
- name: ml-pipeline-ui
env:
- name: DISABLE_GKE_METADATA
value: 'false'
Loading