Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Kubernetes v1.27 #1623

Merged
merged 7 commits into from
May 3, 2023
Merged

Support for Kubernetes v1.27 #1623

merged 7 commits into from
May 3, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Apr 28, 2023 •
edited
Loading

What this PR does / why we need it:
This PR adds support for Kubernetes v1.27. We are now skipping tests for OpenStack on k8s v1.26+ and AWS on k8s v1.27+ since they require external CCM. #1626 is going to fix this for the long term but it requires significant effort.

I intentionally didn't remove support for k8s v1.24 through this PR since it should be done in a separate PR later on.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add support for Kubernetes v1.27

Documentation:

https://docs.kubermatic.com/kubermatic/main/architecture/compatibility/os-support-matrix/

@ahmedwaleedmalik
Support for Kubernetes v1.27
feda355 
Signed-off-by: Waleed Malik <[email protected]>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Apr 28, 2023
@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. docs/tbd Denotes a PR that needs documentation (change) that will be done later. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 28, 2023
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 28, 2023
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-aws

@ahmedwaleedmalik
Refactored code
83c62ff 
Signed-off-by: Waleed Malik <[email protected]>
@ahmedwaleedmalik
Copy link
Member Author

/retest

1 similar comment
@ahmedwaleedmalik
Copy link
Member Author

/retest

@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-aws-arm

1 similar comment
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-aws-arm

@ahmedwaleedmalik ahmedwaleedmalik changed the title WIP: Support for Kubernetes v1.27 Support for Kubernetes v1.27 May 3, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2023
@ahmedwaleedmalik ahmedwaleedmalik force-pushed the k8s-1.27 branch 2 times, most recently from 0008ccd to 291b123 Compare May 3, 2023 08:21
@ahmedwaleedmalik
Refactored code
5583352 
Signed-off-by: Waleed Malik <[email protected]>
@kron4eg
Copy link
Member

kron4eg commented May 3, 2023

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,kron4eg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 38888076f007b0deb722a04358ba84dafdbfb192

@ahmedwaleedmalik
Adjust spot pricing and tests
256da61 
Signed-off-by: Waleed Malik <[email protected]>
@ahmedwaleedmalik
Copy link
Member Author

ahmedwaleedmalik commented May 3, 2023 •
edited
Loading

pull-machine-controller-e2e-azure flaked

failed to update replicas of MachineDeployment ubuntu-1-26-4-azure-1653693113081794560: Internal error occurred: failed calling webhook "machinedeployments.machine-controller.kubermatic.io": failed to call webhook: Post "https://machine-controller-webhook.kube-system.svc:443/machinedeployments?timeout=10s": context deadline exceeded

pull-machine-controller-e2e-aws-spot-instance and pull-machine-controller-e2e-aws-spot-instance-legacy-userdata are failing due to spot pricing.

2023-05-03T09:50:42.759Z error machine-controller machine/controller.go:402 Reconciling failed {"machine": "kube-system/ubuntu-1-24-13-aws-1653686151376015360-7c5b55b4cb-v5484", "error": "failed to create machine at cloudprovider, due to failed create instance at aws, due to operation error EC2: RunInstances, exceeded maximum number of attempts, 100, https response error StatusCode: 500, RequestID: a63c2dc0-3917-4285-a54a-61af54129e6d, api error InsufficientInstanceCapacity: There is no Spot capacity available that matches your request."}

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@kron4eg
Copy link
Member

kron4eg commented May 3, 2023

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 421b67f2b4cb0df2a49a7045eedec61c7986dfd6

@kubermatic-bot kubermatic-bot merged commit a8f4e0f into kubermatic:main May 3, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the k8s-1.27 branch May 3, 2023 12:10
eiabea pushed a commit to anexia-it/machine-controller that referenced this pull request May 8, 2023
@ahmedwaleedmalik @eiabea
Support for Kubernetes v1.27 (kubermatic#1623)
53896bd 
* Support for Kubernetes v1.27

Signed-off-by: Waleed Malik <[email protected]>

* Update build image

Signed-off-by: Waleed Malik <[email protected]>

* Update go dependencies and re-generate fixture data

Signed-off-by: Waleed Malik <[email protected]>

* Refactored code

Signed-off-by: Waleed Malik <[email protected]>

* Skip unsupported in-tree tests for AWS and OpenStack

Signed-off-by: Waleed Malik <[email protected]>

* Refactored code

Signed-off-by: Waleed Malik <[email protected]>

* Adjust spot pricing and tests

Signed-off-by: Waleed Malik <[email protected]>

---------

Signed-off-by: Waleed Malik <[email protected]>
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedwaleedmalik @kron4eg @kubermatic-bot