Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Microsoft.VisualStudio.SlnGen dependency development only #1509

Merged

Conversation

WeihanLi
Copy link
Contributor

This seemed should be a development dependency only, currently, it would be a dependency for the packages

image

Configure Microsoft.VisualStudio.SlnGen PrivateAssets to let it be development only

https://learn.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#controlling-dependency-assets

Configure `Microsoft.VisualStudio.SlnGen` `PrivateAssets`
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2024
Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tg123, WeihanLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 80cdef2 into kubernetes-client:master Jan 30, 2024
14 checks passed
@WeihanLi WeihanLi deleted the vs-slngen-dependency branch January 30, 2024 04:59
@rwkarg
Copy link
Contributor

rwkarg commented Feb 26, 2024

When should a release with this change be expected to be available?

@tg123
Copy link
Member

tg123 commented Feb 26, 2024

pushed 13.0.23

@WeihanLi
Copy link
Contributor Author

pushed 13.0.23

@tg123 seemed the nuget package not pushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants