Actually assign loaded cert when generating pfx

[rmja]

Fix regression in .net 9 when migrating to X509CertificateLoader.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rmja / name: Rasmus Melchior Jacobsen (4b14395, c239a73)

[k8s-ci-robot]

Welcome @rmja!

It looks like this is your first PR to kubernetes-client/csharp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/csharp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[tg123]

thanks for catching this silly mistake

could you please sign cla and double confirm why ut didn't cover it well?
i checked ut when i was doing the upgrade, seems it already covered the case

[rmja]

I found that the test that would have caught this was being skipped for Windows. This is now fixed. I believe that the cla is signed, right?

[tg123]

/LGTM

anyway to make this covered in ut?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmja, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tg123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (master@f7e7613). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/KubernetesClient/CertUtils.cs	50.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1609   +/-   ##
=========================================
  Coverage          ?   70.64%           
=========================================
  Files             ?       89           
  Lines             ?     2681           
  Branches          ?      557           
=========================================
  Hits              ?     1894           
  Misses            ?      787           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rmja]

/LGTM

anyway to make this covered in ut?

This is covered now in the tests! The problem is that the tests that would have detected this were disabled on Windows, and the issue only shows on Windows.

Looking forward to a release with this fix, as Windows compatability is currently broken.