Enable the reuse of cached informers on creation by SharedInformerFactory.

[Sud0x67]

This PR introduces a new constructor parameter, reuseExistingCachedInformer, to the SharedInformerFactory.

The aim is to facilitate the reuse of existing cached informers when creating informers through SharedInformerFactory.

Currently, SharedInformerFactory caches only the first informer created for each API type. Developers who wish to avoid creating a new informer each time must first call SharedInformerFactory#getExistingSharedIndexInformer before proceeding with creation.

By setting reuseExistingCachedInformer to true, SharedInformerFactory will automatically reuse existing cached informers instead of creating new ones. This approach simplifies the process and clearly indicates whether to utilize the cached factory, thereby reducing potential confusion.

The discussion can be found here Issue

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Sud0x67 / name: Sud0x67 (8973a20)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sud0x67
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @Sud0x67!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[Sud0x67]

/test

[k8s-ci-robot]

@Sud0x67: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Sud0x67]

@k8s-ci-robot /test

[Sud0x67]

@k8s-ci-robot /easycla

[Sud0x67]

@k8s-ci-robot /check-cla

[Sud0x67]

@k8s-ci-robot /check-cla

[Sud0x67]

Hi @brendandburns ,

Thanks for your feedback, which primarily focuses on maintaining compatibility and preserving default behaviors. As discussed in this issue, the default behaviors can sometimes be confusing. However, within this pull request, all default behaviors have been retained except for introducing a boolean parameter in the constructor SharedInformerFactory(ApiClient client, ExecutorService threadPool, boolean reuseCache).

To maintain simplicity, I opted not to add an overloaded constructor method like SharedInformerFactory(ApiClient client, ExecutorService threadPool) with reuseCache set to false.

I'd appreciate your thoughts and any other suggestions you might have on this PR.

[yue9944882]

/lgtm

[Sud0x67]

Hey @yue9944882 @brendandburns, it looks like there aren't any more questions on this PR. Could you please approve it? Thanks!