Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing the UID part of the volumeGroupSnapshotRef field #1178

Conversation

leonardoce
Copy link
Contributor

When statically binding a VolumeGroupSnapshot with a VolumeGroupSnapshotContent, the code sets the uid field.

This was not allowed by the CEL validation rules that were imposing a strong immutability on that field.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This PR allows changing the VolumeGroupSnapshotContent.spec.volumeGroupSnapshotRef.uid field during the binding of statically provisioned VolumeGroupSnapshot and VolumeGroupSnapshotContent.

It was currently disallowed by a CEL transition rule.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The `VolumeGroupSnapshotContent.spec.volumeGroupSnapshotRef.uid` field is now mutable. The snapshot controller needs this to bind statically-provisioned VolumeGroupSnapshot and VolumeGroupSnapshotContents correctly.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leonardoce
Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2024
@leonardoce
Copy link
Contributor Author

cc: @xing-yang

@leonardoce
Copy link
Contributor Author

This may be related to #1153

When statically binding a VolumeGroupSnapshot with a
VolumeGroupSnapshotContent, the code sets the `uid` field.

This was not allowed by the CEL validation rules that were imposing a
strong immutability on that field.
@leonardoce
Copy link
Contributor Author

Closing in favor or #1184

@leonardoce leonardoce closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants