-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PV informer and indexer #1182
Conversation
Skipping CI for Draft Pull Request. |
91cff49
to
5c54547
Compare
5c54547
to
6b7f572
Compare
6b7f572
to
95c60a6
Compare
/lgtm Nicely written! Please remember to update all other |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, leonardoce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
95c60a6
to
65bbcad
Compare
/lgtm |
What type of PR is this?
What this PR does / why we need it:
The VolumeGroupSnapshot feature requires looking up the PV object corresponding to a volumeHandle for a known CSI Driver. At this moment, the code uses a List call on the API server, and List calls are particularly expensive.
This patch adds an informer whose lister and indexer are used to alleviate the cost of that call.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This PR does not introduce any user-facing change nor require additional permissions. It's just a performance improvement that will avoid hitting the API server too much.
Does this PR introduce a user-facing change?: