Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include feature gate in snapshotter #1194

Merged
merged 1 commit into from
Nov 20, 2024
Merged

include feature gate in snapshotter #1194

merged 1 commit into from
Nov 20, 2024

Conversation

yati1998
Copy link
Contributor

@yati1998 yati1998 commented Nov 14, 2024 •
edited by xing-yang
Loading

this commit includes feature gate method
to enable the volumeGroupSnapshot

The enable-volume-group-snapshots flag has been replaced by feature-gates flag.
Enable feature gate to enable volumegroupsnapshot, i.e., --feature-gates=CSIVolumeGroupSnapshot=true. 
By default the feature gate is disabled

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 14, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @yati1998. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 14, 2024
@yati1998 yati1998 changed the title include feature gate in snapshotter [WIP] include feature gate in snapshotter Nov 14, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024
nixpanic
nixpanic reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

pkg/features/features.go Outdated Show resolved Hide resolved
cmd/snapshot-controller/main.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2024
@yati1998 yati1998 changed the title [WIP] include feature gate in snapshotter include feature gate in snapshotter Nov 17, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2024
@yati1998
Copy link
Contributor Author

@xing-yang @nixpanic please do review the PR,
I have tested it, this is working good with feature gate

@yati1998
Copy link
Contributor Author 

 containers:
  - args:
    - --feature-gates=CSIVolumeGroupSnapshot=true
    - --v=5
    - --leader-election=true
    image: quay.io/ypadia/snapshotcontroller:featuregate2
    imagePullPolicy: IfNotPresent
    name: snapshot-controller

@yati1998 yati1998 force-pushed the feature-gate branch 4 times, most recently from 836bb91 to 2e895c3 Compare November 18, 2024 11:57
leonardoce
leonardoce reviewed Nov 18, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
xing-yang
xing-yang reviewed Nov 18, 2024
View reviewed changes
pkg/features/features.go
)

func init() {
feature.DefaultMutableFeatureGate.Add(defaultKubernetesFeatureGates)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VolumeGroupSnapshot is a new API. It needs to be disabled by default when moving to Beta.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default it is false only right? check line no 36?

cmd/snapshot-controller/main.go
@@ -228,10 +240,10 @@ func main() {
workqueue.NewItemExponentialFailureRateLimiter(*retryIntervalStart, *retryIntervalMax),
*enableDistributedSnapshotting,
*preventVolumeModeConversion,
*enableVolumeGroupSnapshots,
utilfeature.DefaultFeatureGate.Enabled(features.VolumeGroupSnapshot),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VolumeGroupSnapshot needs to be disabled by default when moving to Beta initially.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this just checks if it is enabled or not, but in features, default value is false only

@yati1998
include feature gate in snapshotter
85b60dd 
this commit includes feature gate method
to enable the volumeGroupSnapshot

Signed-off-by: yati1998 <[email protected]>
@leonardoce
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2024
@leonardoce
Copy link
Contributor

/ok-to-test

@yati1998
Copy link
Contributor Author

@gnufied can you give your final reviews as well?

@gnufied
Copy link
Contributor

gnufied commented Nov 19, 2024

/lgtm

@xing-yang
Copy link
Collaborator

In the release notes, can you add that the feature gate is disabled by default?

@yati1998
Copy link
Contributor Author

In the release notes, can you add that the feature gate is disabled by default?

updated!! please review it again

@xing-yang
Copy link
Collaborator

You need to change --feature-gates=CSIVolumeGroupSnapshot=false to --feature-gates=CSIVolumeGroupSnapshot=true in the release note?

@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang, yati1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9e30bb0 into kubernetes-csi:master Nov 20, 2024
8 checks passed
@huww98
Copy link
Contributor

huww98 commented Nov 22, 2024

We should cleanup --enable-volume-group-snapshots in readme and error message. There are still 6 mentions.

@xing-yang
Copy link
Collaborator

@yati1998 Can you take care of this?

@yati1998
Copy link
Contributor Author

@yati1998 Can you take care of this?

noted

@Madhu-1 Madhu-1 mentioned this pull request Nov 25, 2024
Closed
@xing-yang xing-yang mentioned this pull request Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@nixpanic nixpanic Awaiting requested review from nixpanic

@leonardoce leonardoce Awaiting requested review from leonardoce

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@gnufied gnufied

@xing-yang xing-yang

@leonardoce leonardoce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yati1998 @k8s-ci-robot @leonardoce @gnufied @xing-yang @huww98 @nixpanic