Set VolumeHandle for dynamically provisioned VolumeGroupSnapshots

[leonardoce]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This patch sets the spec.source.volumeHandle field for
volume snapshot contents that are members of a dynamically provisioned volume
group snapshot, like a dynamically provisioned volume snapshot content would do.

The volume snapshot content logic has been improved to consider this case too.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The "spec.source.volumeHandle" field is now set on VolumeSnapshotContents that are members of a dynamically provisioned VolumeGroupSnapshot. This is consistent with dynamically provisioned VolumeSnapshotContents.

[xing-yang]

Can you post your testing results that show VolumeSnapshot and VolumeSnapshotContent fields are set correctly?

[leonardoce]

Can you post your testing results that show VolumeSnapshot and VolumeSnapshotContent fields are set correctly?

Sure! And sorry for the wall of text.

- apiVersion: snapshot.storage.k8s.io/v1
  kind: VolumeSnapshot
  metadata:
    creationTimestamp: "2024-11-19T21:38:35Z"
    finalizers:
    - snapshot.storage.kubernetes.io/volumesnapshot-in-group-protection
    - snapshot.storage.kubernetes.io/volumesnapshot-as-source-protection
    generation: 1
    labels:
      groupsnapshot.storage.k8s.io/volumeGroupSnapshotName: new-groupsnapshot-demo
    name: snapshot-55c8b8f7da1947b1257f455c99d7eb75c932e6146f9eeb467b5c28bf477b0339
    namespace: default
    resourceVersion: "2200178"
    uid: 9b8e0373-f4e7-45d8-a57b-ab14c8bb84b4
  spec:
    source:
      persistentVolumeClaimName: cluster-example-1
  status:
    boundVolumeSnapshotContentName: snapcontent-55c8b8f7da1947b1257f455c99d7eb75c932e6146f9eeb467b5c28bf477b0339
    creationTime: "2024-11-19T21:38:33Z"
    readyToUse: true
    restoreSize: 1Gi
    volumeGroupSnapshotName: new-groupsnapshot-demo
- apiVersion: snapshot.storage.k8s.io/v1
  kind: VolumeSnapshot
  metadata:
    creationTimestamp: "2024-11-19T21:38:35Z"
    finalizers:
    - snapshot.storage.kubernetes.io/volumesnapshot-in-group-protection
    - snapshot.storage.kubernetes.io/volumesnapshot-as-source-protection
    generation: 1
    labels:
      groupsnapshot.storage.k8s.io/volumeGroupSnapshotName: new-groupsnapshot-demo
    name: snapshot-1aa1a114fcb059a99c472690a68a2519ad9518dcf6fc9ab47e019f72e915e4fe
    namespace: default
    resourceVersion: "2200191"
    uid: 35580211-b200-4ed1-a216-b819845e53bb
  spec:
    source:
      persistentVolumeClaimName: cluster-example-1-wal
  status:
    boundVolumeSnapshotContentName: snapcontent-1aa1a114fcb059a99c472690a68a2519ad9518dcf6fc9ab47e019f72e915e4fe
    creationTime: "2024-11-19T21:38:33Z"
    readyToUse: true
    restoreSize: 1Gi
    volumeGroupSnapshotName: new-groupsnapshot-demo
- apiVersion: snapshot.storage.k8s.io/v1
  kind: VolumeSnapshotContent
  metadata:
    creationTimestamp: "2024-11-19T21:38:35Z"
    finalizers:
    - snapshot.storage.kubernetes.io/volumesnapshotcontent-bound-protection
    generation: 2
    labels:
      groupsnapshot.storage.k8s.io/volumeGroupSnapshotHandle: a017f002-a6be-11ef-a7b4-ae8ffed98ae4
    name: snapcontent-1aa1a114fcb059a99c472690a68a2519ad9518dcf6fc9ab47e019f72e915e4fe
    resourceVersion: "2200190"
    uid: 56ae7f8f-b8bf-456d-a8d6-3c36a4fa2930
  spec:
    deletionPolicy: Delete
    driver: hostpath.csi.k8s.io
    source:
      volumeHandle: 145063c3-a591-11ef-a409-4ebdfafda5f0
    sourceVolumeMode: Filesystem
    volumeSnapshotRef:
      kind: VolumeSnapshot
      name: snapshot-1aa1a114fcb059a99c472690a68a2519ad9518dcf6fc9ab47e019f72e915e4fe
      namespace: default
      uid: 35580211-b200-4ed1-a216-b819845e53bb
  status:
    creationTime: 1732052313169593437
    readyToUse: true
    restoreSize: 1073741824
    snapshotHandle: a083db7d-a6be-11ef-a7b4-ae8ffed98ae4
    volumeGroupSnapshotHandle: a017f002-a6be-11ef-a7b4-ae8ffed98ae4
- apiVersion: snapshot.storage.k8s.io/v1
  kind: VolumeSnapshotContent
  metadata:
    creationTimestamp: "2024-11-19T21:38:35Z"
    finalizers:
    - snapshot.storage.kubernetes.io/volumesnapshotcontent-bound-protection
    generation: 2
    labels:
      groupsnapshot.storage.k8s.io/volumeGroupSnapshotHandle: a017f002-a6be-11ef-a7b4-ae8ffed98ae4
    name: snapcontent-55c8b8f7da1947b1257f455c99d7eb75c932e6146f9eeb467b5c28bf477b0339
    resourceVersion: "2200166"
    uid: 1b938a3a-85a7-4150-9540-1479591b4af7
  spec:
    deletionPolicy: Delete
    driver: hostpath.csi.k8s.io
    source:
      volumeHandle: 144f5adc-a591-11ef-a409-4ebdfafda5f0
    sourceVolumeMode: Filesystem
    volumeSnapshotRef:
      kind: VolumeSnapshot
      name: snapshot-55c8b8f7da1947b1257f455c99d7eb75c932e6146f9eeb467b5c28bf477b0339
      namespace: default
      uid: 9b8e0373-f4e7-45d8-a57b-ab14c8bb84b4
  status:
    creationTime: 1732052313169593437
    readyToUse: true
    restoreSize: 1073741824
    snapshotHandle: a017f350-a6be-11ef-a7b4-ae8ffed98ae4
    volumeGroupSnapshotHandle: a017f002-a6be-11ef-a7b4-ae8ffed98ae4

[xing-yang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leonardoce, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment