Use ownership to identify volume group snapshot members #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/L
|
/assign xing-yang |
Madhu-1
reviewed
Dec 2, 2024
xing-yang
reviewed
Dec 2, 2024
leonardoce
force-pushed
the
ownership-alpha
branch
from
0595e03
to
75845d6
Compare
Madhu-1
reviewed
Dec 2, 2024
leonardoce
force-pushed
the
ownership-alpha
branch
from
75845d6
to
2f2a965
Compare
k8s-ci-robot
added
the
lgtm
|
/assign @xing-yang |
xing-yang
reviewed
Dec 2, 2024
Instead of marking the member snapshot object with a label, this PR uses an ownership reference. Member objects are looked up using a new index in the informer cache.
leonardoce
force-pushed
the
ownership-alpha
branch
from
2f2a965
to
c70f946
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leonardoce, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of marking the member snapshot object with a label, this PR uses an ownership reference.
Member objects are looked up using a new index in the informer cache.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR removes the usage of the
groupsnapshot.storage.k8s.io/volumeGroupSnapshotNamelabel, opting for an ownership-based volume group snapshot member tracking as described in the relative comment.The patch fixes an issue in the
csi-snapshottersidecar that was failing to pass the snapshot ids to the DeleteGroupSnapshot RPC endpoint for statically provisioned snapshots with theDeleteretention policy.Which issue(s) this PR fixes:
Fixes #1213
Special notes for your reviewer:
With this PR applied, my smoke tests are passing.
They cover volume group snapshots (static and dynamic provisioning, both retain and delete deletion policy) and volume snapshots (static and dynamic provisioning, both retain and delete deletion policy).
I manually tested creating a volume group snapshot with a name of 73 characters and everything went fine.
Does this PR introduce a user-facing change?: