Fix lint: move to Github Action

[jkh52]

Update golangci-lint from 1.54.0 to v1.56.2, per needed for go1.22 per golangci/golangci-lint#4273.

Introduce a Github Action based linter.

Fix resulting findings.

[jkh52]

Now, golangci-lint appears to succeed but then "hangs". Any ideas, @liangyuanpeng or @cheftako ?

[jkh52]

The lint authors recommend using Github Actions: https://golangci-lint.run/welcome/install/#ci-installation

After we get this in place, we can remove the problematic linter from test-infra.

[jkh52]

Although pull-apiserver-network-proxy-make-lint-master continues to fail, see the successful golangci-lint / lint (pull_request).

/retest

[jkh52]

@cheftako friendly ping.

It would be nice to get lint working again against mainline. I would have liked to simply adjust Makefile but I never solved a remaining mystery why it hangs when invoked from kubekins / test-infra. At the same linter version it succeeds very quickly via Github Action. Migrating lint to Github Actions might be superior going forward, even if we did not have that mystery.

[liangyuanpeng]

I first tried to reproduce it in the local /github action, but with no luck, I am trying to test it by upgrading golangci-lint to 1.59.0 in #664

[cheftako]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, jkh52

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cheftako,jkh52]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment