Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependencies for 1.39 release #2295

Closed
wants to merge 2 commits into from
Closed

Bump dependencies for 1.39 release #2295

wants to merge 2 commits into from

Conversation

ElijahQuinones
Copy link
Member

@ElijahQuinones ElijahQuinones commented Jan 21, 2025 •
edited by AndrewSirenko
Loading

What type of PR is this?

/king cleanup

What is this PR about? / Why do we need it?

Bumps dependencies for the 1.39 release

Notes:

  • We used EKS Distro 1-31-12 tagged images because 1-32-5 images were not released.
  • We kept external resizer at v1.12.0 because v1.13.1 was failing k/k storage conformance tests. The EKS Distro image included patches for CVEs that were in v1.12.0 at the time of this release.

How was this change tested?

make update && make verify && make test as well as CI

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2025
@github-actions GitHub Actions
Copy link

Code Coverage Diff

This PR does not change the code coverage

AndrewSirenko
AndrewSirenko reviewed Jan 21, 2025
View reviewed changes
go.mod Show resolved Hide resolved
@ElijahQuinones ElijahQuinones force-pushed the bumpDeps branch 2 times, most recently from d6d2dd1 to 345a49b Compare January 21, 2025 20:48
@AndrewSirenko
Copy link
Contributor

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 22, 2025
torredil
torredil approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

AndrewSirenko
AndrewSirenko approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

For eddie's final approval after CI passes.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@AndrewSirenko
Copy link
Contributor

/retest

@AndrewSirenko
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
@torredil
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

@ElijahQuinones: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-ebs-csi-driver-external-test-eks 3032b87 link true /test pull-aws-ebs-csi-driver-external-test-eks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@torredil
Copy link
Member

/retest

@AndrewSirenko AndrewSirenko mentioned this pull request Jan 22, 2025
Merged
@AndrewSirenko
Copy link
Contributor

Superceded by #2304

/close

@k8s-ci-robot
Copy link
Contributor

@AndrewSirenko: Closed this PR.

In response to this:

Superceded by #2304

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil torredil approved these changes

@AndrewSirenko AndrewSirenko AndrewSirenko approved these changes

Assignees

@AndrewSirenko AndrewSirenko

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ElijahQuinones @AndrewSirenko @k8s-ci-robot @torredil