Merge pull request #2579 from umagnus/replace_golang_api_win

feat: replace Get-Item powershell cmd with golang api on Windows HostProcess mode

pkg/azuredisk/nodeserver_test.go

@@ -1049,19 +1049,19 @@ func TestNodeExpandVolume(t *testing.T) {
 
 	devicePathErr := testutil.TestError{
 		DefaultError: status.Errorf(codes.NotFound, "could not determine device path(%s), error: %v", targetTest, notFoundErr),
-		WindowsError: status.Errorf(codes.NotFound, "error getting volume from mount. cmd: (Get-Item -Path $Env:mount).Target, output: , error: <nil>"),
+		WindowsError: status.Errorf(codes.NotFound, "error reading link for mount D:\\a\\azuredisk-csi-driver\\azuredisk-csi-driver\\pkg\\azuredisk\\target_test. target  err: readlink D:\\a\\azuredisk-csi-driver\\azuredisk-csi-driver\\pkg\\azuredisk\\target_test: The file or directory is not a reparse point."),
 	}
 	blockSizeErr := testutil.TestError{
 		DefaultError: status.Error(codes.Internal, "could not get size of block volume at path test: error when getting size of block volume at path test: output: , err: exit status 1"),
-		WindowsError: status.Errorf(codes.NotFound, "error getting volume from mount. cmd: (Get-Item -Path $Env:mount).Target, output: , error: <nil>"),
+		WindowsError: status.Errorf(codes.NotFound, "error reading link for mount D:\\a\\azuredisk-csi-driver\\azuredisk-csi-driver\\pkg\\azuredisk\\target_test. target  err: readlink D:\\a\\azuredisk-csi-driver\\azuredisk-csi-driver\\pkg\\azuredisk\\target_test: The file or directory is not a reparse point."),
 	}
 	resizeErr := testutil.TestError{
 		DefaultError: status.Errorf(codes.Internal, "could not resize volume \"test\" (\"test\"):  resize of device test failed: %v. resize2fs output: ", notFoundErr),
-		WindowsError: status.Errorf(codes.NotFound, "error getting volume from mount. cmd: (Get-Item -Path $Env:mount).Target, output: , error: <nil>"),
+		WindowsError: status.Errorf(codes.NotFound, "error reading link for mount D:\\a\\azuredisk-csi-driver\\azuredisk-csi-driver\\pkg\\azuredisk\\target_test. target  err: readlink D:\\a\\azuredisk-csi-driver\\azuredisk-csi-driver\\pkg\\azuredisk\\target_test: The file or directory is not a reparse point."),
 	}
 	sizeTooSmallErr := testutil.TestError{
 		DefaultError: status.Errorf(codes.Internal, "resize requested for %v, but after resizing volume size was %v", volumehelper.RoundUpGiB(stdCapacityRange.RequiredBytes), volumehelper.RoundUpGiB(stdCapacityRange.RequiredBytes/2)),
-		WindowsError: status.Errorf(codes.NotFound, "error getting volume from mount. cmd: (Get-Item -Path $Env:mount).Target, output: , error: <nil>"),
+		WindowsError: status.Errorf(codes.NotFound, "error reading link for mount D:\\a\\azuredisk-csi-driver\\azuredisk-csi-driver\\pkg\\azuredisk\\target_test. target  err: readlink D:\\a\\azuredisk-csi-driver\\azuredisk-csi-driver\\pkg\\azuredisk\\target_test: The file or directory is not a reparse point."),
 	}
 
 	notFoundErrAction := func() ([]byte, []byte, error) {

pkg/os/volume/volume.go

@@ -19,6 +19,7 @@ package volume
 import (
 	"encoding/json"
 	"fmt"
+	"os"
 	"regexp"
 	"strconv"
 	"strings"
@@ -209,13 +210,12 @@ func getTarget(mount string, depth int) (string, error) {
 	if depth == 0 {
 		return "", fmt.Errorf("maximum depth reached on mount %s", mount)
 	}
-	cmd := "(Get-Item -Path $Env:mount).Target"
-	out, err := azureutils.RunPowershellCmd(cmd, fmt.Sprintf("mount=%s", mount))
-	if err != nil || len(out) == 0 {
-		return "", fmt.Errorf("error getting volume from mount. cmd: %s, output: %s, error: %v", cmd, string(out), err)
+	target, err := os.Readlink(mount)
+	if err != nil {
+		return "", fmt.Errorf("error reading link for mount %s. target %s err: %v", mount, target, err)
 	}
-	volumeString := strings.TrimSpace(string(out))
-	if !strings.HasPrefix(volumeString, "Volume") {
+	volumeString := strings.TrimSpace(target)
+	if !strings.HasPrefix(volumeString, "Volume") && !strings.HasPrefix(volumeString, "\\\\?\\Volume") {
 		return getTarget(volumeString, depth-1)
 	}