Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: migrate azureclient to track2 sdk in e2e test suite #1922

Merged
merged 1 commit into from
Oct 16, 2023
Merged

test: migrate azureclient to track2 sdk in e2e test suite #1922

merged 1 commit into from
Oct 16, 2023

Conversation

MartinForReal
Copy link
Contributor

@MartinForReal MartinForReal commented Aug 3, 2023 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 3, 2023
@k8s-ci-robot k8s-ci-robot requested review from cvvz and ZeroMagic August 3, 2023 04:52
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 3, 2023
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2023
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 21, 2023
@MartinForReal MartinForReal changed the title [WIP]migrate to track2 sdk [WIP]migrate to track2 sdk in e2e test suite Oct 13, 2023
@MartinForReal MartinForReal changed the title [WIP]migrate to track2 sdk in e2e test suite Migrate azureclient to track2 sdk in e2e test suite Oct 13, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2023
@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

so this PR only changes the e2e test client, it does not touch the driver functionality code now, right? @MartinForReal

@MartinForReal
Copy link
Contributor Author

Yes! @andyzhangx

@andyzhangx
Copy link
Member

/retest

1 similar comment
@andyzhangx
Copy link
Member

/retest

@andyzhangx andyzhangx changed the title Migrate azureclient to track2 sdk in e2e test suite test: migrate azureclient to track2 sdk in e2e test suite Oct 13, 2023
@andyzhangx
Copy link
Member

/kind test

@andyzhangx
Copy link
Member

/retest

1 similar comment
@MartinForReal
Copy link
Contributor Author

/retest

andyzhangx
andyzhangx approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 16, 2023 •
edited
Loading

@MartinForReal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-e2e-single-az 638cb8d link true /test pull-azuredisk-csi-driver-e2e-single-az
pull-azuredisk-csi-driver-e2e-windows-containerd 638cb8d link true /test pull-azuredisk-csi-driver-e2e-windows-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 3a016e0 into kubernetes-sigs:master Oct 16, 2023
10 checks passed
@umagnus umagnus mentioned this pull request Jun 17, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@cvvz cvvz Awaiting requested review from cvvz

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinForReal @andyzhangx @k8s-ci-robot