fix: Ultra and PremiumV2 disk snapshot delay issue

[andyzhangx]

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: Ultra and PremiumV2 disk snapshot delay issue

create snapshot on 100GB Ultra disk would requires 6min, this PR waits until it succeeds

• create snapshot on 100GB Ultra disk would requires 6min

I0830 14:08:22.405778       1 utils.go:77] GRPC call: /csi.v1.Controller/CreateSnapshot
I0830 14:08:22.405803       1 utils.go:78] GRPC request: {"name":"snapshot-43b7d797-d33b-4cfd-8e13-e048a8cc7a34","parameters":{"incremental":"true"},"source_volume_id":"/subscriptions/b9d2281e-dcd5-4dfd-9a97-0d50377cdf76/resourceGroups/mc_andy-aks126_andy-aks126_eastus2/providers/Microsoft.Compute/disks/pvc-a9aaf673-1fce-440c-a365-55729223a1bf"}
I0830 14:08:22.405983       1 controllerserver.go:925] begin to create snapshot(snapshot-43b7d797-d33b-4cfd-8e13-e048a8cc7a34, incremental: true) under rg(mc_andy-aks126_andy-aks126_eastus2) region(eastus2)
I0830 14:08:29.737513       1 azuredisk.go:461] copy snapshot(snapshot-43b7d797-d33b-4cfd-8e13-e048a8cc7a34) under rg(mc_andy-aks126_andy-aks126_eastus2) completionPercent: 0.000000

I0830 14:14:19.743400       1 azuredisk.go:458] copy snapshot(snapshot-43b7d797-d33b-4cfd-8e13-e048a8cc7a34) under rg(mc_andy-aks126_andy-aks126_eastus2) complete
I0830 14:14:19.743454       1 controllerserver.go:939] create snapshot(snapshot-43b7d797-d33b-4cfd-8e13-e048a8cc7a34) under rg(mc_andy-aks126_andy-aks126_eastus2) region(eastus2) successfully

• create snapshot on standard disk

I0903 13:08:57.101957       1 utils.go:77] GRPC call: /csi.v1.Controller/CreateSnapshot
I0903 13:08:57.102016       1 utils.go:78] GRPC request: {"name":"snapshot-0a738491-cfd0-4f90-a4ce-1e99d8a09ba6","parameters":{"incremental":"true"},"source_volume_id":"/subscriptions/b9d2281e-dcd5-4dfd-9a97-0d50377cdf76/resourceGroups/mc_andy-aks126_andy-aks126_eastus2/providers/Microsoft.Compute/disks/pvc-7f99bade-becd-43a3-ba3f-dd2fddae9363"}
I0903 13:08:57.102227       1 controllerserver.go:925] begin to create snapshot(snapshot-0a738491-cfd0-4f90-a4ce-1e99d8a09ba6, incremental: true) under rg(mc_andy-aks126_andy-aks126_eastus2) region(eastus2)
I0903 13:08:59.618496       1 azuredisk.go:430] snapshot(snapshot-0a738491-cfd0-4f90-a4ce-1e99d8a09ba6) under rg(mc_andy-aks126_andy-aks126_eastus2) has no SnapshotProperties or CompletionPercent is nil
I0903 13:08:59.618514       1 azuredisk.go:445] snapshot(snapshot-0a738491-cfd0-4f90-a4ce-1e99d8a09ba6) under rg(mc_andy-aks126_andy-aks126_eastus2) complete
I0903 13:08:59.618530       1 controllerserver.go:938] create snapshot(snapshot-0a738491-cfd0-4f90-a4ce-1e99d8a09ba6) under rg(mc_andy-aks126_andy-aks126_eastus2) region(eastus2) successfully
I0903 13:08:59.640307       1 azure_metrics.go:115] "Observed Request Latency" latency_seconds=2.538028882 request="azuredisk_csi_driver_controller_create_snapshot" resource_group="mc_andy-aks126_andy-aks126_eastus2" subscription_id="b9d2281e-dcd5-4dfd-9a97-0d50377cdf76" source="disk.csi.azure.com" source_resource_id="/subscriptions/b9d2281e-dcd5-4dfd-9a97-0d50377cdf76/resourceGroups/mc_andy-aks126_andy-aks126_eastus2/providers/Microsoft.Compute/disks/pvc-7f99bade-becd-43a3-ba3f-dd2fddae9363" snapshot_name="snapshot-0a738491-cfd0-4f90-a4ce-1e99d8a09ba6" result_code="succeeded"
I0903 13:08:59.640332       1 utils.go:84] GRPC response: {"snapshot":{"creation_time":{"nanos":489035300,"seconds":1693746537},"ready_to_use":true,"size_bytes":21474836480,"snapshot_id":"/subscriptions/b9d2281e-dcd5-4dfd-9a97-0d50377cdf76/resourceGroups/mc_andy-aks126_andy-aks126_eastus2/providers/Microsoft.Compute/snapshots/snapshot-0a738491-cfd0-4f90-a4ce-1e99d8a09ba6","source_volume_id":"/subscriptions/b9d2281e-dcd5-4dfd-9a97-0d50377cdf76/resourceGroups/mc_andy-aks126_andy-aks126_eastus2/providers/Microsoft.Compute/disks/pvc-7f99bade-becd-43a3-ba3f-dd2fddae9363"}}

Which issue(s) this PR fixes:

Fixes #

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:

Release note:

fix: Ultra and PremiumV2 disk snapshot delay issue

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyzhangx]

/retest

[andyzhangx]

/retest

[andyzhangx]

/cherrypick release-1.29

[k8s-infra-cherrypick-robot]

@andyzhangx: new pull request created: #1980

In response to this:

/cherrypick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andyzhangx]

/cherrypick release-1.28

[k8s-infra-cherrypick-robot]

@andyzhangx: #1953 failed to apply on top of branch "release-1.28":

Applying: fix: Ultra and PremiumV2 disk snapshot delay issue
Applying: feat: add wait-for-snapshot-ready flag
Using index info to reconstruct a base tree...
M	pkg/azuredisk/azuredisk.go
M	pkg/azuredisk/controllerserver.go
M	pkg/azuredisk/fake_azuredisk.go
M	pkg/azurediskplugin/main.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azurediskplugin/main.go
CONFLICT (content): Merge conflict in pkg/azurediskplugin/main.go
Auto-merging pkg/azuredisk/fake_azuredisk.go
Auto-merging pkg/azuredisk/controllerserver.go
Auto-merging pkg/azuredisk/azuredisk.go
CONFLICT (content): Merge conflict in pkg/azuredisk/azuredisk.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 feat: add wait-for-snapshot-ready flag
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.