Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add correct userAgent for the driver #2570

Closed
wants to merge 1 commit into from

Conversation

MartinForReal
Copy link
Contributor

@MartinForReal MartinForReal commented Oct 24, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
chores: set useragent for e2e clients
Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:
kubernetes/kubernetes@9c92b37#diff-3145c766434ba7221bf0a6effe8f70bb744e9a214cac1d4a0ec5427414c0eecf
move GenerateVolumeName to csi driver
kubernetes/kubernetes@f55588f#diff-19f37de624b324e650f830dc887c4a5bba1831378790c62b09aee69a4ba0c2e9L302
test framework is updated.
Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MartinForReal
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 24, 2024
@MartinForReal MartinForReal force-pushed the master branch 9 times, most recently from f69656c to 281c8ee Compare October 24, 2024 05:39
@MartinForReal
Copy link
Contributor Author

/retest

2 similar comments
@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@MartinForReal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-external-e2e-single-az aeb73ed link true /test pull-azuredisk-csi-driver-external-e2e-single-az
pull-azuredisk-csi-driver-e2e-capz-windows-2022 aeb73ed link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2022

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andyzhangx andyzhangx changed the title chores: set useragent for e2e clients test: add UserAgent for e2e client Oct 25, 2024
@andyzhangx andyzhangx changed the title test: add UserAgent for e2e client fix: add correct userAgent for the driver Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants