Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase format timeout as 300s by default #2673

Merged

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
chore: increase format timeout as 300s by default

I have observed that it costs 83s to format a 30TB disk:

I1126 07:00:17.583179       1 utils.go:105] GRPC call: /csi.v1.Node/NodeStageVolume
I1126 07:00:17.583205       1 utils.go:106] GRPC request: {"publish_context":{"LUN":"0"},"staging_target_path":"/var/lib/kubelet/plugins/kubernetes.io/csi/disk.csi.azure.com/a621ec8e71c62e341ae812c978f90f00af8507b7dcb7380a9430e86b5fe65ac8/globalmount","volume_capability":{"AccessType":{"Mount":{}},"access_mode":{"mode":7}},"volume_context":{"csi.storage.k8s.io/pv/name":"pvc-c0cc6ce6-039c-43a2-a0e1-99f9261364b0","csi.storage.k8s.io/pvc/name":"persistent-storage-statefulset-azuredisk-bigdisk-1","csi.storage.k8s.io/pvc/namespace":"default","requestedsizegib":"30720","skuName":"StandardSSD_LRS","storage.kubernetes.io/csiProvisionerIdentity":"1730541755160-5145-disk.csi.azure.com"},"volume_id":"/subscriptions/b9d2281e-dcd5-4dfd-9a97-0d50377cdf76/resourceGroups/MC_andy-aks129_andy-aks129_eastus2/providers/Microsoft.Compute/disks/pvc-c0cc6ce6-039c-43a2-a0e1-99f9261364b0"}
I1126 07:00:17.589777       1 azure_common_linux.go:185] azureDisk - found /dev/disk/azure/scsi1/lun0 by sdc under /dev/disk/azure/scsi1/
I1126 07:00:17.590191       1 nodeserver.go:157] NodeStageVolume: formatting /dev/disk/azure/scsi1/lun0 and mounting at /var/lib/kubelet/plugins/kubernetes.io/csi/disk.csi.azure.com/a621ec8e71c62e341ae812c978f90f00af8507b7dcb7380a9430e86b5fe65ac8/globalmount with mount options([])
I1126 07:00:17.590211       1 mount_linux.go:577] Attempting to determine if disk "/dev/disk/azure/scsi1/lun0" is formatted using blkid with args: ([-p -s TYPE -s PTTYPE -o export /dev/disk/azure/scsi1/lun0])
I1126 07:00:17.650717       1 mount_linux.go:580] Output: ""
I1126 07:00:17.650773       1 mount_linux.go:515] Disk "/dev/disk/azure/scsi1/lun0" appears to be unformatted, attempting to format as type: "ext4" with options: [-F -m0 /dev/disk/azure/scsi1/lun0]
I1126 07:01:40.772543       1 mount_linux.go:526] Disk successfully formatted (mkfs): ext4 - /dev/disk/azure/scsi1/lun0 /var/lib/kubelet/plugins/kubernetes.io/csi/disk.csi.azure.com/a621ec8e71c62e341ae812c978f90f00af8507b7dcb7380a9430e86b5fe65ac8/globalmount
I1126 07:01:40.772572       1 mount_linux.go:544] Attempting to mount disk /dev/disk/azure/scsi1/lun0 in ext4 format at /var/lib/kubelet/plugins/kubernetes.io/csi/disk.csi.azure.com/a621ec8e71c62e341ae812c978f90f00af8507b7dcb7380a9430e86b5fe65ac8/globalmount
I1126 07:01:40.776172       1 mount_linux.go:218] Mounting cmd (mount) with arguments (-t ext4 -o defaults /dev/disk/azure/scsi1/lun0 /var/lib/kubelet/plugins/kubernetes.io/csi/disk.csi.azure.com/a621ec8e71c62e341ae812c978f90f00af8507b7dcb7380a9430e86b5fe65ac8/globalmount)
I1126 07:01:42.708854       1 nodeserver.go:161] NodeStageVolume: format /dev/disk/azure/scsi1/lun0 and mounting at /var/lib/kubelet/plugins/kubernetes.io/csi/disk.csi.azure.com/a621ec8e71c62e341ae812c978f90f00af8507b7dcb7380a9430e86b5fe65ac8/globalmount successfully.
I1126 07:01:42.713965       1 mount_linux.go:577] Attempting to determine if disk "/dev/disk/azure/scsi1/lun0" is formatted using blkid with args: ([-p -s TYPE -s PTTYPE -o export /dev/disk/azure/scsi1/lun0])
I1126 07:01:42.722061       1 mount_linux.go:580] Output: "DEVNAME=/dev/disk/azure/scsi1/lun0\nTYPE=ext4\n"
I1126 07:01:42.727231       1 resizefs_linux.go:137] ResizeFs.needResize - checking mounted volume /dev/disk/azure/scsi1/lun0
I1126 07:01:42.740734       1 resizefs_linux.go:141] Ext size: filesystem size=32985348833280, block size=4096
I1126 07:01:42.743251       1 resizefs_linux.go:156] Volume /dev/disk/azure/scsi1/lun0: device size=32985348833280, filesystem size=32985348833280, block size=4096
I1126 07:01:42.755924       1 utils.go:112] GRPC response: {}

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2024
@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-external-e2e-single-az ffc2b8e link true /test pull-azuredisk-csi-driver-external-e2e-single-az
pull-azuredisk-csi-driver-e2e-migration-windows ffc2b8e link true /test pull-azuredisk-csi-driver-e2e-migration-windows
pull-azuredisk-csi-driver-e2e-capz-windows-2019-hostprocess ffc2b8e link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2019-hostprocess

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit e2e2416 into kubernetes-sigs:master Nov 27, 2024
19 of 23 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.31

@andyzhangx
Copy link
Member Author

/cherrypick release-1.30

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #2674

In response to this:

/cherrypick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #2675

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants