Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update max data disk count table for D family v6 series #2900

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

Phaow
Copy link
Contributor

@Phaow Phaow commented Feb 24, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • update max data disk count table for D family v6 series.
    The Dlsv6, Dldsv6, Dsv6, Ddsv6 series instances are GA recently while their max data disk count are incorrect.
$ /bin/azurediskplugin --version
Build Date: "2025-02-20T00:28:56Z"
Compiler: gc
Driver Name: disk.csi.azure.com
Driver Version: v1.31.1
Git Commit: 20f616920a1c1d4ca11008bf6f117d2079bd781f
Go Version: go1.23.4 (Red Hat 1.23.4-1.el9) X:strictfipsruntime
Platform: linux/amd64
Topology Key: N/A

$ kubectl get no/pewang-dxv6-a-qf9ck-worker-eastus2-l49ft -oyaml|grep 'instance'
    beta.kubernetes.io/instance-type: Standard_D8lds_v6
    node.kubernetes.io/instance-type: Standard_D8lds_v6
$ kubectl get csinode pewang-dxv6-a-qf9ck-worker-eastus2-l49ft -oyaml|yq .spec
drivers:
  - name: file.csi.azure.com
    nodeID: pewang-dxv6-a-qf9ck-worker-eastus2-l49ft
    topologyKeys: null
  - allocatable:
      count: 16
    name: disk.csi.azure.com
    nodeID: pewang-dxv6-a-qf9ck-worker-eastus2-l49ft
    topologyKeys:
      - topology.disk.csi.azure.com/zone
      - topology.kubernetes.io/zone

$ az vm list-sizes -l eastus -o tsv | awk -F '\t' '{print "\""$3"\":"$1","}' | sort | uniq|grep 'Standard_D8lds_v6'
"Standard_D8lds_v6":24,   

The update refer to kubernetes/kubernetes#77461 (comment).

$ cat vmsizelist.final|grep -Ei 'Standard_D\d{1,3}s_v6|Standard_D\d{1,3}ds_v6|Standard_D\d{1,3}ls_v6|Standard_D\d{1,3}lds_v6'
"STANDARD_D128DS_V6":64,
"STANDARD_D128LDS_V6":64,
"STANDARD_D128LS_V6":64,
"STANDARD_D128S_V6":64,
"STANDARD_D16DS_V6":48,
"STANDARD_D16LDS_V6":48,
"STANDARD_D16LS_V6":48,
"STANDARD_D16S_V6":48,
"STANDARD_D192DS_V6":64,
"STANDARD_D2DS_V6":8,
"STANDARD_D2LDS_V6":8,
"STANDARD_D2LS_V6":8,
"STANDARD_D2S_V6":8,
"STANDARD_D32DS_V6":64,
"STANDARD_D32LDS_V6":64,
"STANDARD_D32LS_V6":64,
"STANDARD_D32S_V6":64,
"STANDARD_D48DS_V6":64,
"STANDARD_D48LDS_V6":64,
"STANDARD_D48LS_V6":64,
"STANDARD_D48S_V6":64,
"STANDARD_D4DS_V6":12,
"STANDARD_D4LDS_V6":12,
"STANDARD_D4LS_V6":12,
"STANDARD_D4S_V6":12,
"STANDARD_D64DS_V6":64,
"STANDARD_D64LDS_V6":64,
"STANDARD_D64LS_V6":64,
"STANDARD_D64S_V6":64,
"STANDARD_D8DS_V6":24,
"STANDARD_D8LDS_V6":24,
"STANDARD_D8LS_V6":24,
"STANDARD_D8S_V6":24,
"STANDARD_D96DS_V6":64,
"STANDARD_D96LDS_V6":64,
"STANDARD_D96LS_V6":64,
"STANDARD_D96S_V6":64,

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Phaow
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @Phaow!

It looks like this is your first PR to kubernetes-sigs/azuredisk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/azuredisk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Phaow. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 24, 2025
@Phaow
Copy link
Contributor Author

Phaow commented Feb 24, 2025

Hi @andyzhangx , could you help take a look when you get a chance? Thank you!

@Phaow
Copy link
Contributor Author

Phaow commented Feb 24, 2025

/assign @andyzhangx

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 25, 2025
@k8s-ci-robot
Copy link
Contributor

@Phaow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-external-e2e-single-az 8776acf link true /test pull-azuredisk-csi-driver-external-e2e-single-az

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Phaow
Copy link
Contributor Author

Phaow commented Feb 25, 2025

/retest

@andyzhangx andyzhangx merged commit 21ab49e into kubernetes-sigs:master Feb 25, 2025
21 of 23 checks passed
@andyzhangx
Copy link
Member

/cherrypick release-1.31

@andyzhangx
Copy link
Member

/cherrypick release-1.30

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #2901

In response to this:

/cherrypick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #2902

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants