Skip to content

Commit

Permalink
removed TODOs and created github issue for them instead
Browse files Browse the repository at this point in the history
  • Loading branch information
nawazkh committed Nov 19, 2024
1 parent 2c85c47 commit cbba70f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions Tiltfile
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ if "default_registry" in settings:

os_arch = str(local("go env GOARCH")).rstrip("\n")

# TODO: no one is clearing MGMT_CLUSTER_NAME when using KIND, so this is always going to be true. Improve this logic.
if "aks" in settings.get("kustomize_substitutions", {}).get("MGMT_CLUSTER_NAME", ""):
print("Using AKS as management cluster, setting os_arch to amd64")
os_arch = "amd64"
Expand Down Expand Up @@ -409,7 +408,6 @@ def deploy_worker_templates(template, substitutions):
flavor_cmd += "; until " + kubectl_cmd + " --kubeconfig ./${CLUSTER_NAME}.kubeconfig get configmap kubeadm-config --namespace=kube-system > /dev/null 2>&1; do sleep 5; done"
flavor_cmd += "; " + kubectl_cmd + " --kubeconfig ./${CLUSTER_NAME}.kubeconfig create namespace calico-system --dry-run=client -o yaml | " + kubectl_cmd + " --kubeconfig ./${CLUSTER_NAME}.kubeconfig apply -f -; " + kubectl_cmd + " --kubeconfig ./${CLUSTER_NAME}.kubeconfig get configmap kubeadm-config --namespace=kube-system -o yaml | sed 's/namespace: kube-system/namespace: calico-system/' | " + kubectl_cmd + " --kubeconfig ./${CLUSTER_NAME}.kubeconfig apply -f -"

# TODO: no one is clearing MGMT_CLUSTER_NAME when using KIND, so this is always going to be true. Improve this logic.
if "aks" in settings.get("kustomize_substitutions", {}).get("MGMT_CLUSTER_NAME", ""):
flavor_cmd += peer_vnets()

Expand Down

0 comments on commit cbba70f

Please sign in to comment.