Included a Makefile target to install yamllint, skipped linting autog…

…enerated config dir, fixed linting issues seen

.yamllint

@@ -1,5 +1,8 @@
 extends: default
 
+ignore:
+  - config       # Skip autogenerated config dir from liniting
+
 rules:
   # Rules to control the number of spaces around operators
   braces:
@@ -17,27 +20,24 @@ rules:
   hyphens:
     max-spaces-after: 1
 
-# Rules to control indentation
+  # Rules to control indentation
   indentation:
     spaces: consistent              # Spaces should be consistently used for indentation
     indent-sequences: whatever      # Either indenting or not indenting individual block sequences is OK
   comments-indentation: enable      # Comments should be indented the same as the content
 
-# Rules to control lines
+  # Rules to control lines
   line-length:
-    max: 120                                       # Maximum 120 characters per line
+    max: 150                                       # Maximum 150 characters per line
     allow-non-breakable-words: true                # Allow long words without breaks
     allow-non-breakable-inline-mappings: true      # Allow long inline mappings without breaks
   empty-lines:
     max: 2                                         # Maximum two consecutive empty lines allowed
   trailing-spaces: enable                          # Ensure no trailing spaces at the end of lines
-
-# Other rules
-  comments:
-    min-spaces-from-content: 1    # At least one space required between content and comment
-  key-duplicates: enable          # Ensure no duplicate keys in mappings
-  document-start:
-    present: false                # Do not require document start marker
 
-
-
+  # Other rules
+  comments:
+    min-spaces-from-content: 1                        # At least one space required between content and comment
+  key-duplicates: enable                              # Ensure no duplicate keys in mappings
+  truthy:
+    allowed-values: ['true', 'false', 'on', 'off']    # Allow only these values for boolean scalars

Makefile

@@ -150,6 +150,11 @@ vet:
 help:  # Display this help
 	@awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n  make \033[36m<target>\033[0m\n\nTargets:\n"} /^[0-9A-Za-z_-]+:.*?##/ { printf "  \033[36m%-45s\033[0m %s\n", $$1, $$2 } /^\$$\([0-9A-Za-z_-]+\):.*?##/ { gsub("_","-", $$1); printf "  \033[36m%-45s\033[0m %s\n", tolower(substr($$1, 3, length($$1)-7)), $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST)
 
+# Install yamllint if not present
+.PHONY: install-yamllint
+install-yamllint:
+	@which yamllint > /dev/null || (echo "Installing yamllint..." && pip install yamllint)
+
 ## --------------------------------------
 ## Generate / Manifests
 ## --------------------------------------

metadata.yaml

@@ -22,4 +22,4 @@ releaseSeries:
     contract: v1beta1
   - major: 0
     minor: 7
-    contract: v1beta1 
+    contract: v1beta1

templates/bases/vpc/kcp.yaml

@@ -26,14 +26,14 @@ spec:
     initConfiguration:
       nodeRegistration:
         criSocket: /var/run/containerd/containerd.sock
-        kubeletExtraArgs: 
+        kubeletExtraArgs:
           cloud-provider: external
           eviction-hard: 'nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%'
     joinConfiguration:
       discovery: {}
       nodeRegistration:
         criSocket: /var/run/containerd/containerd.sock
-        kubeletExtraArgs: 
+        kubeletExtraArgs:
           cloud-provider: external
           eviction-hard: 'nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%'
 ---

templates/cluster-template-powervs-clusterclass/cluster-with-kcp.yaml

@@ -53,12 +53,12 @@ spec:
             ref:
               apiVersion: bootstrap.cluster.x-k8s.io/v1beta1
               kind: KubeadmConfigTemplate
-              name:  "${IBMPOWERVS_CLUSTER_CLASS_NAME}-md-0"
+              name: "${IBMPOWERVS_CLUSTER_CLASS_NAME}-md-0"
           infrastructure:
             ref:
               apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
               kind: IBMPowerVSMachineTemplate
-              name:  "${IBMPOWERVS_CLUSTER_CLASS_NAME}-worker-machinetemplate"
+              name: "${IBMPOWERVS_CLUSTER_CLASS_NAME}-worker-machinetemplate"
 ---
 apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
 kind: IBMPowerVSClusterTemplate

templates/cluster-template-powervs/kcp.yaml

@@ -13,4 +13,3 @@ spec:
       nodeRegistration:
         kubeletExtraArgs:
           provider-id: ibmpowervs://${CLUSTER_NAME}/'{{ v1.local_hostname }}'
-

templates/cluster-template-vpc-clusterclass/cluster-with-kcp.yaml

@@ -104,13 +104,13 @@ spec:
         initConfiguration:
           nodeRegistration:
             criSocket: /var/run/containerd/containerd.sock
-            kubeletExtraArgs: 
+            kubeletExtraArgs:
               cloud-provider: external
               eviction-hard: 'nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%'
         joinConfiguration:
           discovery: {}
           nodeRegistration:
             criSocket: /var/run/containerd/containerd.sock
-            kubeletExtraArgs: 
+            kubeletExtraArgs:
               cloud-provider: external
               eviction-hard: 'nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%'

templates/cluster-template/cluster.yaml

@@ -5,4 +5,3 @@ metadata:
   namespace: "${NAMESPACE}"
   labels:
     ccm: external
-

templates/cluster-template/kcp.yaml

@@ -12,4 +12,3 @@ spec:
       apiServer:
         extraArgs:
           cloud-provider: external
-

test/e2e/data/cni/calico/calico.yaml

@@ -4229,7 +4229,7 @@ rules:
     resources:
       - endpointslices
     verbs:
-      - watch 
+      - watch
       - list
   - apiGroups: [""]
     resources: