-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bootstrap only additional listener #2059
base: main
Are you sure you want to change the base?
Support bootstrap only additional listener #2059
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hamzy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @hamzy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
Add an option to the AdditionalListenerSpec to signify that this pool should only contain the boostrap node. An example of this would be for port 22 since every master node also has ssh but we need the public load balance to only connect to the bootstrap ssh server.
b08add6
to
375cf4a
Compare
Overall I like the idea just thinking, Can we generalise this rather than sticking only to bootstrap configuration? |
Add an option to the AdditionalListenerSpec to signify that this pool should only contain the boostrap node. An example of this would be for port 22 since every master node also has ssh but we need the public load balancer to only connect to the bootstrap ssh server and not randomly to any one of the four nodes.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/area provider/ibmcloud
Release note: