Skip to content

Commit

Permalink
Fix CRD generation
Browse files Browse the repository at this point in the history
When moving the webhooks we didn't separate CRD generation from webhook
generation, meaning controller-gen was looking for CRDs to generate in
pkg/webhook. This resulted in CRDs not being generated.
  • Loading branch information
mdbooth committed Mar 6, 2024
1 parent d76b07d commit 30ba121
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,11 @@ generate-conversion-gen: $(CONVERSION_GEN)
.PHONY: generate-manifests
generate-manifests: $(CONTROLLER_GEN) ## Generate manifests e.g. CRD, RBAC etc.
$(CONTROLLER_GEN) \
paths=./pkg/webhooks/... \
paths=./api/... \
crd:crdVersions=v1 \
output:crd:dir=$(CRD_ROOT) \
output:crd:dir=$(CRD_ROOT)
$(CONTROLLER_GEN) \
paths=./pkg/webhooks/... \
output:webhook:dir=$(WEBHOOK_ROOT) \
webhook
$(CONTROLLER_GEN) \
Expand Down

0 comments on commit 30ba121

Please sign in to comment.