Skip to content

Commit

Permalink
E2E: Use CAPI production images
Browse files Browse the repository at this point in the history
Use CAPI production images instead of from GCR.

Don't prepull cert-manager. We always let these images get out of
sync, causing us to pull double instead of saving anything. We end up
with different tags in e2e_conf.yaml and in the Makefile.
Additionally, CAPI may change what version is installed by clusterctl by
default, causing us to pull *two* wrong versions and then install a
third if we don't remember to check when bumping CAPI.

Signed-off-by: Lennart Jern <[email protected]>
  • Loading branch information
lentzi90 committed Nov 29, 2024
1 parent 7e898a9 commit 45bf827
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 18 deletions.
9 changes: 3 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -209,12 +209,9 @@ e2e-image: docker-build

# Pull all the images references in test/e2e/data/e2e_conf.yaml
test-e2e-image-prerequisites:
docker pull gcr.io/k8s-staging-cluster-api/cluster-api-controller:v1.6.0
docker pull gcr.io/k8s-staging-cluster-api/kubeadm-bootstrap-controller:v1.6.0
docker pull gcr.io/k8s-staging-cluster-api/kubeadm-control-plane-controller:v1.6.0
docker pull quay.io/jetstack/cert-manager-cainjector:v1.12.1
docker pull quay.io/jetstack/cert-manager-webhook:v1.12.1
docker pull quay.io/jetstack/cert-manager-controller:v1.12.1
docker pull registry.k8s.io/cluster-api/cluster-api-controller:v1.8.5
docker pull registry.k8s.io/cluster-api/kubeadm-bootstrap-controller:v1.8.5
docker pull registry.k8s.io/cluster-api/kubeadm-control-plane-controller:v1.8.5

CONFORMANCE_E2E_ARGS ?= -kubetest.config-file=$(KUBETEST_CONF_PATH)
CONFORMANCE_E2E_ARGS += $(E2E_ARGS)
Expand Down
15 changes: 3 additions & 12 deletions test/e2e/data/e2e_conf.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
---
# E2E test scenario using local dev images and manifests built from the source tree for following providers:
# - cluster-api
# - bootstrap kubeadm
# - control-plane kubeadm
# - openstack

# To run tests, run the following from the root of this repository.
Expand All @@ -12,21 +9,15 @@
managementClusterName: capo-e2e

images:
- name: gcr.io/k8s-staging-cluster-api/cluster-api-controller:v1.8.5
- name: registry.k8s.io/cluster-api/cluster-api-controller:v1.8.5
loadBehavior: tryLoad
- name: gcr.io/k8s-staging-cluster-api/kubeadm-bootstrap-controller:v1.8.5
- name: registry.k8s.io/cluster-api/kubeadm-bootstrap-controller:v1.8.5
loadBehavior: tryLoad
- name: gcr.io/k8s-staging-cluster-api/kubeadm-control-plane-controller:v1.8.5
- name: registry.k8s.io/cluster-api/kubeadm-control-plane-controller:v1.8.5
loadBehavior: tryLoad
# Use local dev images built source tree;
- name: gcr.io/k8s-staging-capi-openstack/capi-openstack-controller:e2e
loadBehavior: mustLoad
- name: quay.io/jetstack/cert-manager-cainjector:v1.14.5
loadBehavior: tryLoad
- name: quay.io/jetstack/cert-manager-webhook:v1.14.5
loadBehavior: tryLoad
- name: quay.io/jetstack/cert-manager-controller:v1.14.5
loadBehavior: tryLoad

providers:
- name: cluster-api
Expand Down

0 comments on commit 45bf827

Please sign in to comment.