-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Remove v1alpha7
#2405
🌱 Remove v1alpha7
#2405
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/retest |
/test pull-cluster-api-provider-openstack-e2e-full-test |
/test pull-cluster-api-provider-openstack-e2e-full-test |
/test pull-cluster-api-provider-openstack-e2e-full-test |
/test pull-cluster-api-provider-openstack-e2e-full-test |
/test pull-cluster-api-provider-openstack-e2e-full-test |
/test pull-cluster-api-provider-openstack-e2e-full-test |
This API isn't served anymore since v0.12, we can remove it now.
/test pull-cluster-api-provider-openstack-e2e-full-test |
Some issue with deleting the bastion port? 🤔
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
To support upgrades from 0.10 where the bastion port name was named after the namespace + cluster name, we need to take care of removing that port as well during an upgrade.
/test pull-cluster-api-provider-openstack-e2e-full-test |
I think this is good to go, I'll wait for a second reviewer and then we can merge it. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
The API wasn't served in 0.12.x so we can safely remove it now.