Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove v1alpha7 #2405

Merged
merged 2 commits into from
Jan 31, 2025
Merged

🌱 Remove v1alpha7 #2405

merged 2 commits into from
Jan 31, 2025

Conversation

EmilienM
Copy link
Contributor

What this PR does / why we need it:

The API wasn't served in 0.12.x so we can safely remove it now.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 30, 2025
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 2a8c1a8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/679ce39ea7b1a10008a22943
😎 Deploy Preview https://deploy-preview-2405--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM
Copy link
Contributor Author

/retest

@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2025
@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2025
@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

This API isn't served anymore since v0.12, we can remove it now.
@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@lentzi90
Copy link
Contributor

Some issue with deleting the bastion port? 🤔

I0131 03:25:33.786603       1 port.go:344] "Deleting cluster ports" controller="openstackcluster" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="OpenStackCluster" OpenStackCluster="clusterctl-upgrade/clusterctl-upgrade-workload-aywaio" namespace="clusterctl-upgrade" name="clusterctl-upgrade-workload-aywaio" reconcileID="cc6b4329-e562-48d1-8ef3-cc075816f6f4" cluster="clusterctl-upgrade-workload-aywaio" networkID="bda3bdc3-766b-49b1-8448-e079d980cea1" portList=[{"id":"228aed55-10cf-42f9-baf6-0d902774d5c4","network_id":"bda3bdc3-766b-49b1-8448-e079d980cea1","name":"clusterctl-upgrade-clusterctl-upgrade-workload-aywaio-bastion-0","description":"Created by cluster-api-provider-openstack cluster clusterctl-upgrade-clusterctl-upgrade-workload-aywaio","admin_state_up":true,"status":"DOWN","mac_address":"fa:16:3e:fd:bf:18","fixed_ips":[{"subnet_id":"860a0ea1-6f4f-4f27-8a01-e2aaba6a97dc","ip_address":"10.6.0.173"}],"tenant_id":"4ca151e4e6f24d6b861c4ac784143ccc","project_id":"4ca151e4e6f24d6b861c4ac784143ccc","device_owner":"","security_groups":["7337cbaf-2f7c-441e-826a-83203c9f76e9"],"device_id":"","allowed_address_pairs":[],"tags":[],"propagate_uplink_status":false,"revision_number":7,"created_at":"2025-01-31T03:12:15Z","updated_at":"2025-01-31T03:22:17Z"},{"id":"781bea59-d304-4f83-91b3-d0ed75df777d","network_id":"bda3bdc3-766b-49b1-8448-e079d980cea1","name":"","description":"","admin_state_up":true,"status":"DOWN","mac_address":"fa:16:3e:1e:9e:36","fixed_ips":[{"subnet_id":"860a0ea1-6f4f-4f27-8a01-e2aaba6a97dc","ip_address":"10.6.0.2"}],"tenant_id":"4ca151e4e6f24d6b861c4ac784143ccc","project_id":"4ca151e4e6f24d6b861c4ac784143ccc","device_owner":"network:distributed","security_groups":[],"device_id":"ovnmeta-bda3bdc3-766b-49b1-8448-e079d980cea1","allowed_address_pairs":[],"tags":[],"propagate_uplink_status":false,"revision_number":2,"created_at":"2025-01-31T03:10:58Z","updated_at":"2025-01-31T03:10:58Z"}]
E0131 03:25:33.853771       1 controller.go:341] "Reconciler error" err="failed to delete network: Expected HTTP response code [202 204] when accessing [DELETE http://10.0.3.15:9696/networking/v2.0/networks/bda3bdc3-766b-49b1-8448-e079d980cea1], but got 409 instead: {\"NeutronError\": {\"type\": \"NetworkInUse\", \"message\": \"Unable to complete operation on network bda3bdc3-766b-49b1-8448-e079d980cea1. There are one or more ports still in use on the network, id for these ports is: 228aed55-10cf-42f9-baf6-0d902774d5c4.\", \"detail\": \"\"}}" controller="openstackcluster" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="OpenStackCluster" OpenStackCluster="clusterctl-upgrade/clusterctl-upgrade-workload-aywaio" namespace="clusterctl-upgrade" name="clusterctl-upgrade-workload-aywaio" reconcileID="cc6b4329-e562-48d1-8ef3-cc075816f6f4"
I0131 03:25:33.854292       1 recorder.go:104] "Failed to delete network k8s-clusterapi-cluster-clusterctl-upgrade-clusterctl-upgrade-workload-aywaio with id bda3bdc3-766b-49b1-8448-e079d980cea1: Expected HTTP response code [202 204] when accessing [DELETE http://10.0.3.15:9696/networking/v2.0/networks/bda3bdc3-766b-49b1-8448-e079d980cea1], but got 409 instead: {\"NeutronError\": {\"type\": \"NetworkInUse\", \"message\": \"Unable to complete operation on network bda3bdc3-766b-49b1-8448-e079d980cea1. There are one or more ports still in use on the network, id for these ports is: 228aed55-10cf-42f9-baf6-0d902774d5c4.\", \"detail\": \"\"}}" logger="events" type="Warning" object={"kind":"OpenStackCluster","namespace":"clusterctl-upgrade","name":"clusterctl-upgrade-workload-aywaio","uid":"6444db56-bd49-4c7d-87cd-15ba275ca87f","apiVersion":"infrastructure.cluster.x-k8s.io/v1beta1","resourceVersion":"4675"} reason="Faileddeletenetwork"

@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test
in the meantime while I investigate

To support upgrades from 0.10 where the bastion port name was named
after the namespace + cluster name, we need to take care of removing
that port as well during an upgrade.
@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

I think this is good to go, I'll wait for a second reviewer and then we can merge it.

@EmilienM
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2025
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit d9d28af into kubernetes-sigs:main Jan 31, 2025
10 checks passed
@EmilienM EmilienM deleted the v1alpha7 branch January 31, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants