🐛 KCPTemplate & DockerClusterTemplate webhook: default before immutability check #10638
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/assign @fabriziopandini @chrischdi |
sbueringer
added
area/provider/control-plane-kubeadm
sbueringer
changed the title
|
/cherry-pick release-1.7 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.6 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
controlplane/kubeadm/internal/webhooks/kubeadmcontrolplanetemplate_test.go
Outdated
Show resolved
Hide resolved
…ity check Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-fix-webhooks
branch
from
9ae5ab8
to
155de2c
Compare
k8s-ci-robot
added
size/M
|
/test pull-cluster-api-e2e-main |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0a877f3e1c8037571ea21be6d681f58cda05ba20
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@sbueringer: new pull request created: #10646 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sbueringer: new pull request created: #10647 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Immutability checks should not fail if the only difference is defaulted fields. In these cases changes are fine because introducing new defaulting for fields should never change the behavior. (e.g. setting format to CloudConfig leads to the same behavior as not setting it)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #