Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add dry-run CreateOrUpdate call in clusterctl upgrade e2e tests #11349

Conversation

cahillsf
Copy link
Member

What this PR does / why we need it:
Ensures that applying the cluster template in clusterctl upgrade e2e tests succeeds in dry-run before actually creating/updating

as discussed here: #11133 (comment)

/area e2e-testing

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 29, 2024
@cahillsf cahillsf marked this pull request as ready for review October 29, 2024 01:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2024
@cahillsf cahillsf force-pushed the add-dry-run-to-clusterctl-upgrade-e2e branch from 5536da8 to 5c4209f Compare October 29, 2024 01:05
@cahillsf
Copy link
Member Author

/test pull-cluster-api-e2e-main

@cahillsf cahillsf force-pushed the add-dry-run-to-clusterctl-upgrade-e2e branch from 5c4209f to b837c34 Compare October 29, 2024 12:54
@sbueringer
Copy link
Member

Thank you very much!!

/test pull-cluster-api-e2e-main

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 38831309b863a879d4c6239640a5ffd34e78c9d5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7c0dd0c into kubernetes-sigs:main Oct 29, 2024
18 of 19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 29, 2024
@cahillsf
Copy link
Member Author

/cherry-pick release-1.8

@k8s-infra-cherrypick-robot

@cahillsf: new pull request created: #11458

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants