-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add dry-run CreateOrUpdate call in clusterctl upgrade e2e tests #11349
🌱 Add dry-run CreateOrUpdate call in clusterctl upgrade e2e tests #11349
Conversation
Skipping CI for Draft Pull Request. |
5536da8
to
5c4209f
Compare
/test pull-cluster-api-e2e-main |
5c4209f
to
b837c34
Compare
Thank you very much!! /test pull-cluster-api-e2e-main /lgtm |
LGTM label has been added. Git tree hash: 38831309b863a879d4c6239640a5ffd34e78c9d5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.8 |
@cahillsf: new pull request created: #11458 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Ensures that applying the cluster template in clusterctl upgrade e2e tests succeeds in dry-run before actually creating/updating
as discussed here: #11133 (comment)
/area e2e-testing