🐛 Improve context handling in ClusterCache #11445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/needs-area
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-cc-context-fixes
branch
from
ae0f23c
to
5a345f1
Compare
sbueringer
commented
Nov 19, 2024
| @@ -263,7 +265,7 @@ func createCachedClient(ctx context.Context, clusterAccessorConfig *clusterAcces | |||
| defer cacheSyncCtxCancel() | |||
| if !cache.WaitForCacheSync(cacheSyncCtx) { | |||
| cache.Stop() | |||
| return nil, nil, errors.Wrapf(cacheCtx.Err(), "error when waiting for cache to sync") | |||
| return nil, nil, fmt.Errorf("error when waiting for cache to sync: %w", cacheSyncCtx.Err()) | |||
There was a problem hiding this comment.
Before we used errors.Wrap and with the wrong context. The result was that if the cache actually never synced. cacheCtx.Err() was nil and then errors.Wrapf also returned nil. This leads to panics down the line
sbueringer
added
the
area/clustercachetracker
vincepri
approved these changes
Nov 19, 2024
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e58d96e4bb7a63dd8f61cc3fcb22d2df48057f2c
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Context: https://kubernetes.slack.com/archives/C8TSNPY4T/p1731096886259339
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #