Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add v1beta2 conditions to CABPK #11452

Merged
merged 1 commit into from
Nov 21, 2024
Merged

🌱 Add v1beta2 conditions to CABPK #11452

merged 1 commit into from
Nov 21, 2024
+181 −6

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Rif #11105

/area provider/bootstrap-kubeadm

@k8s-ci-robot k8s-ci-robot added area/provider/bootstrap-kubeadm Issues or PRs related to CAPBK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 20, 2024
@fabriziopandini fabriziopandini mentioned this pull request Nov 20, 2024
Open
98 tasks
chrischdi
chrischdi reviewed Nov 21, 2024
View reviewed changes
bootstrap/kubeadm/api/v1beta1/v1beta2_condition_consts.go Outdated
// KubeadmConfigReadyV1Beta2Reason surfaces when the KubeadmConfig is ready.
KubeadmConfigReadyV1Beta2Reason = clusterv1.ReadyV1Beta2Reason

// KubeadmConfigNotReadyV1Beta2Reason surfaces when the KubeadmConfig is NOT ready.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// KubeadmConfigNotReadyV1Beta2Reason surfaces when the KubeadmConfig is NOT ready.
// KubeadmConfigNotReadyV1Beta2Reason surfaces when the KubeadmConfig is not ready.

bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go
Type: bootstrapv1.KubeadmConfigDataSecretAvailableV1Beta2Condition,
Status: metav1.ConditionFalse,
Reason: bootstrapv1.KubeadmConfigDataSecretNotAvailableV1Beta2Reason,
Message: "Failed to read content from secrets for spec.files",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For resolving this, a user needs to lookup the error from the logs right? Should we mention something here?

Also ok for me to see this as implicit and not worth to mention.

(note same below 1x, and 3 more times in line 722 - 752, and 3 more times line 874 - 904)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back and forth on this.
It is true that we are not adding full disclosure of the issue, but I think that "Failed to read content from secrets for spec.files" is enough to find the issue without the need of reading the logs (if points to content from secrets in spec.files, usually there are not many of them).
Same for the other messages

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 18441d7 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chrischdi
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 97af8b34feca3095eb939c7e1ac23a04d1e544ce

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2b6669b into kubernetes-sigs:main Nov 21, 2024
17 of 18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@g-gaston g-gaston Awaiting requested review from g-gaston

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/bootstrap-kubeadm Issues or PRs related to CAPBK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziopandini @k8s-ci-robot @chrischdi