🌱 crs: implement ResourcesApplied v1beta2 condition #11467
Conversation
k8s-ci-robot
added
area/conditions
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
| ResourcesAppliedV1beta2Reason = "Applied" | ||
|
|
||
| // ResourcesAppliedApplyFailedV1beta2Reason is the reason used when applying at least one of the resources to one of the matching clusters failed. | ||
| ResourcesAppliedApplyFailedV1beta2Reason = "ApplyFailed" |
There was a problem hiding this comment.
what about using NotApplied for consistency with other reasons?
| // ResourcesAppliedRetrievingResourceFailedV1beta2Reason is the reason used when resources are not successfully retrieved. | ||
| ResourcesAppliedRetrievingResourceFailedV1beta2Reason = "RetrievingResourceFailed" | ||
|
|
||
| // ResourcesAppliedWrongSecretTypeV1beta2Reason is the reason used when the the Secret's type in the resource list is not supported. |
There was a problem hiding this comment.
| // ResourcesAppliedWrongSecretTypeV1beta2Reason is the reason used when the the Secret's type in the resource list is not supported. | |
| // ResourcesAppliedWrongSecretTypeV1beta2Reason is the reason used when the Secret's type in the resource list is not supported. |
| ResourcesAppliedApplyFailedV1beta2Reason = "ApplyFailed" | ||
|
|
||
| // ResourcesAppliedRemoteClusterClientFailedV1beta2Reason is the reason used on failures during getting the remote cluster client. | ||
| ResourcesAppliedRemoteClusterClientFailedV1beta2Reason = "RemoteClusterClientFailed" |
There was a problem hiding this comment.
What about using InternalError when the error + eventually changing the message (same for ClusterMatchFailed and RetrievingResourceFailed.
I will keep WrongSecretType as it is because this is a user configuration error
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #11105
/area conditions