-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add addon provider fleet to registry #11806
✨ Add addon provider fleet to registry #11806
Conversation
63234a4
to
8188841
Compare
@@ -108,7 +108,8 @@ const ( | |||
|
|||
// Add-on providers. | |||
const ( | |||
HelmAddonProviderName = "helm" | |||
HelmAddonProviderName = "helm" | |||
FleetAddonProviderName = "fleet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have to use a org prefix: https://cluster-api.sigs.k8s.io/developer/providers/contracts/clusterctl#adding-a-provider-to-clusterctl
Given that rancher-sandbox & rancher are both owned by rancher, I think rancher-fleet
is fine according to our policy
080e5bf
to
5c66ce7
Compare
Signed-off-by: Danil-Grigorev <[email protected]>
5c66ce7
to
4ee11f1
Compare
Very nice, thank you! /approve |
@sbueringer: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: ba1eeb1df15071503a873bc852c6babf5302a5a8
|
@sbueringer: new pull request created: #11829 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Adds CAAPF to the registry of addon providers.
This allows to initialize provider with
clusterctl init --addon=rancher-fleet
for a quick-start configuration.Addon provider Fleet provides integration point between CAPI and Fleet GitOps solution. Addon is responsible for automatic import of CAPI clusters as a Fleet
Cluster
, which provisions fleet-agent on matching cluster.Aside from GitOps functionality, default configuration can be used to deploy
Bundle
andHelmApp
resources in the child clusters matching selectors.Here is a demo of docker cluster deployment with automatic
Calico
CNI
helm chart installation and configuration:Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #