Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add addon provider fleet to registry #11806

Merged

Conversation

Danil-Grigorev
Copy link
Member

@Danil-Grigorev Danil-Grigorev commented Feb 5, 2025

What this PR does / why we need it:

Adds CAAPF to the registry of addon providers.

This allows to initialize provider with clusterctl init --addon=rancher-fleet for a quick-start configuration.

Addon provider Fleet provides integration point between CAPI and Fleet GitOps solution. Addon is responsible for automatic import of CAPI clusters as a Fleet Cluster, which provisions fleet-agent on matching cluster.

Aside from GitOps functionality, default configuration can be used to deploy Bundle and HelmApp resources in the child clusters matching selectors.

Here is a demo of docker cluster deployment with automatic Calico CNI helm chart installation and configuration:

asciicast

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 5, 2025
@Danil-Grigorev Danil-Grigorev force-pushed the caapf-provider-addition branch from 63234a4 to 8188841 Compare February 5, 2025 19:27
@@ -108,7 +108,8 @@ const (

// Add-on providers.
const (
HelmAddonProviderName = "helm"
HelmAddonProviderName = "helm"
FleetAddonProviderName = "fleet"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to use a org prefix: https://cluster-api.sigs.k8s.io/developer/providers/contracts/clusterctl#adding-a-provider-to-clusterctl

Given that rancher-sandbox & rancher are both owned by rancher, I think rancher-fleet is fine according to our policy

@Danil-Grigorev Danil-Grigorev force-pushed the caapf-provider-addition branch 2 times, most recently from 080e5bf to 5c66ce7 Compare February 6, 2025 09:53
@Danil-Grigorev Danil-Grigorev force-pushed the caapf-provider-addition branch from 5c66ce7 to 4ee11f1 Compare February 6, 2025 09:55
@sbueringer
Copy link
Member

Very nice, thank you!

/approve
/area clusterctl
/cherry-pick release-1.9

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to this:

Very nice, thank you!

/approve
/area clusterctl
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/clusterctl Issues or PRs related to clusterctl and removed do-not-merge/needs-area PR is missing an area label labels Feb 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ba1eeb1df15071503a873bc852c6babf5302a5a8

@k8s-ci-robot k8s-ci-robot merged commit 5f2ce5b into kubernetes-sigs:main Feb 11, 2025
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Feb 11, 2025
@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #11829

In response to this:

Very nice, thank you!

/approve
/area clusterctl
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants