Add optional support for including ecr-credential-provider #1570
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
AverageMarcus
force-pushed
the
ecr_cred_provider
branch
2 times, most recently
from
9ddbc76 to
9b1e777
Compare
k8s-ci-robot
added
the
lgtm
images/capi/Makefile
Outdated
| @@ -287,7 +289,8 @@ COMMON_POWERVS_VAR_FILES := packer/config/kubernetes.json \ | |||
| packer/config/goss-args.json \ | |||
| packer/config/common.json \ | |||
| packer/config/ppc64le/common.json \ | |||
| packer/config/additional_components.json | |||
| packer/config/additional_components.json \ | |||
| packer/config/ecr_credential_provider.json | |||
There was a problem hiding this comment.
Looks like extra tabs crept in here.
k8s-ci-robot
removed
the
lgtm
Signed-off-by: Marcus Noble <[email protected]>
AverageMarcus
force-pushed
the
ecr_cred_provider
branch
from
11b6a08 to
e563d89
Compare
|
Thanks @mboersma I think all those are addressed now and I've squashed commits. |
| packer/config/common.json \ | ||
| packer/config/ppc64le/common.json \ | ||
| packer/config/additional_components.json | ||
| packer/config/ppc64le/containerd.json \ |
There was a problem hiding this comment.
This was me making the indentation consistent with the lines already above. They now all use tabs instead of a mix of tabs and spaces.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| ecr_credential_provider_version: v1.31.0 | ||
| ecr_credential_provider_os: linux | ||
| ecr_credential_provider_arch: amd64 | ||
| ecr_credential_provider_base_url: https://storage.googleapis.com/k8s-artifacts-prod/binaries/cloud-provider-aws |
There was a problem hiding this comment.
Should this be using the https://artifacts.k8s.io/ endpoint instead of the Google specific one https://storage.googleapis.com/k8s-artifacts-prod/?
Change description
Adds a new ansible role that can be optional enabled via the
ecr_credential_providerboolean var that will install and configure the use of ecr-credential-provider to allow pulling images from ECR registries.Related issues
Additional context