Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GetWaitingPod #121

Merged
merged 31 commits into from
Jan 19, 2025
Merged

Support GetWaitingPod #121

merged 31 commits into from
Jan 19, 2025

Conversation

chansuke
Copy link
Member

@chansuke chansuke commented Sep 14, 2024 •
edited
Loading

What type of PR is this?

Adding GetWaitingPod of framework.Handle

What this PR does / why we need it:

Which issue(s) this PR fixes:

Partof #73

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support GetWaitingPod

What are the benchmark results of this change?

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 14, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 14, 2024
@chansuke chansuke force-pushed the feat/support-get-waiting-pod branch from 0a95a76 to 56a7a11 Compare September 18, 2024 02:51
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 18, 2024
@chansuke chansuke force-pushed the feat/support-get-waiting-pod branch from 4480280 to 29db872 Compare September 23, 2024 13:23
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2024
@chansuke chansuke force-pushed the feat/support-get-waiting-pod branch from a1117c5 to 6851e39 Compare October 19, 2024 09:55
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 19, 2024
@chansuke chansuke marked this pull request as ready for review October 19, 2024 11:13
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2024
@chansuke
Copy link
Member Author

searching Test_guestPool_bindingCycles error

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2024
@sanposhiho
Copy link
Member

/cc @utam0k @Gekko0114

sanposhiho
sanposhiho reviewed Nov 12, 2024
View reviewed changes
guest/handle/imports.go Show resolved Hide resolved
scheduler/plugin/host_test.go Outdated Show resolved Hide resolved
@chansuke chansuke requested a review from sanposhiho November 16, 2024 04:31
sanposhiho
sanposhiho reviewed Nov 19, 2024
View reviewed changes
guest/handle/handle.go Outdated Show resolved Hide resolved
sanposhiho
sanposhiho reviewed Nov 30, 2024
View reviewed changes
guest/api/types.go Outdated Show resolved Hide resolved
guest/handle/handle.go Outdated Show resolved Hide resolved
sanposhiho
sanposhiho reviewed Jan 11, 2025
View reviewed changes
guest/internal/mem/mem.go Outdated Show resolved Hide resolved
scheduler/plugin/plugin_test.go Outdated Show resolved Hide resolved
scheduler/plugin/plugin_test.go Outdated Show resolved Hide resolved
scheduler/test/testdata.go Outdated Show resolved Hide resolved
scheduler/test/util.go Outdated Show resolved Hide resolved
@chansuke chansuke requested a review from sanposhiho January 11, 2025 06:39
sanposhiho
sanposhiho reviewed Jan 11, 2025
View reviewed changes
scheduler/test/testdata.go Outdated Show resolved Hide resolved
scheduler/test/testdata.go Outdated Show resolved Hide resolved
scheduler/plugin/plugin_test.go Outdated Show resolved Hide resolved
@chansuke chansuke requested a review from sanposhiho January 14, 2025 12:32
sanposhiho
sanposhiho reviewed Jan 18, 2025
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly. Only one nit.

scheduler/plugin/plugin_test.go Outdated Show resolved Hide resolved
@chansuke chansuke requested a review from sanposhiho January 18, 2025 22:54
sanposhiho
sanposhiho approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Awesome!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chansuke, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 23b11a7 into kubernetes-sigs:main Jan 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho approved these changes

@codefromthecrypt codefromthecrypt Awaiting requested review from codefromthecrypt

@Gekko0114 Gekko0114 Awaiting requested review from Gekko0114

@utam0k utam0k Awaiting requested review from utam0k

Assignees

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chansuke @sanposhiho @k8s-ci-robot