-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support EventRecorder #83
Conversation
e09782b
to
2eea1b5
Compare
08826cb
to
9e3fa2e
Compare
9e3fa2e
to
c00c0cd
Compare
5a9aed8
to
e50c23f
Compare
return "" | ||
} | ||
|
||
func (t testPod) GetKind() string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ABI doesn't include kind and resouce version. So we return static values here
ce5dbc9
to
0c830d8
Compare
/assign @sanposhiho , Created a PR. PTAL. Thanks, |
/assign |
0c830d8
to
103cf64
Compare
b4fa058
to
478b0b6
Compare
@sanposhiho , |
16228bc
to
1cba723
Compare
1cba723
to
947ad1d
Compare
Hi @sanposhiho @codefromthecrypt |
I'm curious to see the benchmark result, can you update your PR description, following the instruction: kube-scheduler-wasm-extension/.github/PULL_REQUEST_TEMPLATE.md Lines 53 to 65 in 73a62c8
|
8055bb3
to
699a8c3
Compare
699a8c3
to
bee7f2c
Compare
@sanposhiho, |
/label tide/merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gekko0114, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Optionally add one or more of the following kinds if applicable:
/kind api-change
What this PR does / why we need it:
Support EventRecorder
Which issue(s) this PR fixes:
Part of #73
Special notes for your reviewer:
Does this PR introduce a user-facing change?
What are the benchmark results of this change?