-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Cilium Helm Chart deployment #11430
Add support for Cilium Helm Chart deployment #11430
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HoKim98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @HoKim98. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@HoKim98 Thanks for starting this PR discussion, but unfortunately, in my experience, |
Maybe we should deprecate or at least encourage switching to custom_cni in the Cilium case as we had a long history of lagging behind Cilium deployment changes. |
Another idea I had was that you could write examples to documentation, and I think many beginners would be confused when they see |
I completely agree! Along with PR #11432, I will address the issue by creating a manual for users who utilize |
PR Type
/kind feature
What this PR Does / Why We Need It
kube_network_plugin: "cilium-helm"
Which Issue(s) this PR Fixes
Potentially fixes #10938, #11047, #11110
Special Notes for Your Reviewer
Following the presentation at KubeCon 2023, Cilium has expanded significantly, showcasing various features and technical integrations. As of version 1.16.0, Cilium maintains an extensive Helm values file encompassing 3524 lines. This large-scale project, unfortunately, poses a challenge for swift integration into community-driven projects like Kubespray. Therefore, I propose enabling the deployment of Cilium CNI using their official Helm Chart, allowing Kubespray to focus solely on compatibility. This approach aims to ease the burden on community contributors by eliminating the need to meticulously track Cilium's development trends.
Although Cilium CNI can currently be installed via custom_cni, this method does not leverage Kubespray functionalities such as reset or
kube_*
variables.This PR supports the installation of Cilium CNI. However, deployment in offline environments is not yet supported and remains an outstanding task.
Does this PR Introduce a User-Facing Change?
No, this new deployment method is activated only when
kube_network_plugin == "cilium-helm"
.