-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Prioritize 'access_ip' over 'ip' in etcd configuration for better flexibility in isolated cluster #11725
base: master
Are you sure you want to change the base?
Conversation
…ress' for client and peer URLs in template
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: M-JavadHeydarpour The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @M-JavadHeydarpour. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
…ip' for etcd configuration
…_access_addresses_list, etcd_metrics_addresses, etcd_peer_addresses, etcd_events_peer_addresses to prioritize 'access_ip' over 'ip' for all endpoints and member definitions
6eae20d
to
ba02b2d
Compare
ba02b2d
to
b5a7ee7
Compare
What type of PR is this?
/kind bug
/kind feature
What this PR does / why we need it:
This pull request refactors the etcd configuration to prioritize
access_ip
overip
in several places in the Kubespray defaults. This change ensures that etcd nodes use the correctaccess_ip
for communication between nodes and for accessing services like events and metrics. It simplifies handling in environments where nodes have multiple IP addresses (e.g., internal and external).Which issue(s) this PR fixes:
Fixes #10445
Fixes #11560
Special notes for your reviewer:
access_ip
field is now prioritized in the etcd configuration over theip
field for more reliable communication.roles/kubespray-defaults/defaults/main/main.yml
, particularly for etcd, etcd peer, etcd events, and metrics endpoints.Does this PR introduce a user-facing change?: