Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(spyglass/lenses/html) add allow-forms to sandbox #294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(spyglass/lenses/html) add allow-forms to sandbox #294

wants to merge 1 commit into from

Commits on Oct 8, 2024

  1. (spyglass/lenses/html) add allow-forms to sandbox 

    This adds allow-forms to the iframe sandbox.

> Blocked form submission to '' because the form's frame is sandboxed
and the 'allow-forms' permission is not set.

This allow's us to click the <a href=link-to-buildbuddy-invocation
target=_blank> which links to streaming build results on buildbuddy,
as we use bazel with remote builders on buildbuddy.io and the buil-logs
uploaded to S3 only contains this hyperlink.

With this change we allow chrome to handle the login process at
buildbuddy.io which requires a form-post to handle login over SSO.

https://web.dev/articles/sandboxed-iframes

Original lens PR: kubernetes/test-infra#10208

Later changes that are similar to this one:

allow same-origin: kubernetes-sigs@b9a0167
allow popups: kubernetes/test-infra#23069

Signed-off-by: Roy Sindre Norangshol <[email protected]>
    @norrs
    norrs committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0b11741 View commit details
    Browse the repository at this point in the history