Improve the apparmor read-write file permissions to allow any file in a directory if already two files are allowed #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/L
ccojocar
requested review from
saschagrunert
and removed request for
JAORMX and
Vincent056
ccojocar
force-pushed
the
improve-filepath-apparmor
branch
from
c158cce
to
5aa5eed
Compare
|
@ccojocar do you mind a rebase? |
Change-Id: I6fe2e9669c8f6c58f141aa77be3626581c5c07ce Signed-off-by: Cosmin Cojocar <[email protected]>
…ead-write premissions Change-Id: Id5799bc8897d3579bf7518d54ef243510b9ba361 Signed-off-by: Cosmin Cojocar <[email protected]>
Change-Id: I3dc2bcc46ba2e416888bb7b53e6fc13ad6b060f6 Signed-off-by: Cosmin Cojocar <[email protected]>
ccojocar
force-pushed
the
improve-filepath-apparmor
branch
from
5aa5eed
to
051fe5e
Compare
Thanks, done it! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2572 +/- ##
==========================================
- Coverage 45.50% 41.33% -4.17%
==========================================
Files 79 109 +30
Lines 7782 18256 +10474
==========================================
+ Hits 3541 7547 +4006
- Misses 4099 10211 +6112
- Partials 142 498 +356
|
saschagrunert
approved these changes
Nov 19, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
It improves the apparmor read-write file permissions to allow any files if at least two files are allowed. There
are binaries like nginx which typically creates files with random name on every start in the
/etc/nginx/conf.d/directory. The random named files cannot be captured in advance and allowed in the apparmor profile, therefore any file needs to be allowed.Which issue(s) this PR fixes:
Does this PR have test?
Yes
Special notes for your reviewer:
Does this PR introduce a user-facing change?