fix(cli): session.Run is sensitive to quoting on Windows host #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mloskot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/cc @knabben This fixes the issue that I was verbosely discussing on Slack. |
There is a strange issue with SSH executor via session.Run
on Windows host (i.e. Windows SSH client) which seems to be
prone to failure depending on particular arrangements of quote,
double-quotes, etc. in PowerShell command.
For example, this fails
output, err := r.run(`Enable-NetFirewallRule -DisplayGroup "Remote Desktop"`)
while this succeeds
output, err := r.run(`Enable-NetFirewallRule -DisplayGroup 'Remote Desktop'`)
Wrapping the command with { and } also seems to solve
this problem.
Interestingly, this issue seems not reproducible Linux host.
mloskot
force-pushed
the
ml/swdt-cli-fix-fragile-ssh-run-on-windows
branch
from
49b59af to
2d48619
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a strange issue with SSH executor via session.Run
on Windows host (i.e. Windows SSH client) which seems to be
prone to failure depending on particular arrangements of quote,
double-quotes, etc. in PowerShell command.
For example, this fails
while this succeeds
Wrapping the command with
{and}also seems to solve this problem, effectivelysession.Runexecuting this with successInterestingly, this issue seems not reproducible Linux host.