Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CSI Proxy and enable privileged containers for windows #3164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikhilbarge
Copy link
Contributor

What this PR does / why we need it:

Replace CSI Proxy for Windows to fix issues with windows volume mount

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
Manual testing performed

Special notes for your reviewer:

Release note:

Replace CSI Proxy for Windows

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nikhilbarge
Once this PR has been reviewed and has the lgtm label, please assign akankshapanse for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 19, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nikhilbarge. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 19, 2025
@nikhilbarge nikhilbarge force-pushed the CNAS-7821_remove_CSI_proxy branch from 9a74a8b to 827dfdf Compare January 19, 2025 13:14
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2025
@nikhilbarge nikhilbarge force-pushed the CNAS-7821_remove_CSI_proxy branch from 827dfdf to 6c5248a Compare January 19, 2025 14:25
@nikhilbarge nikhilbarge changed the title Replace CSI Proxy for Windows Upgrade CSI Proxy and enable privileged containers for windows Jan 19, 2025
@nikhilbarge nikhilbarge force-pushed the CNAS-7821_remove_CSI_proxy branch from 6c5248a to 009fbca Compare January 19, 2025 14:48
@nikhilbarge nikhilbarge force-pushed the CNAS-7821_remove_CSI_proxy branch 2 times, most recently from 3488aea to 4a5a82f Compare February 14, 2025 09:39
@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2025
@xing-yang xing-yang added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 14, 2025
@nikhilbarge nikhilbarge force-pushed the CNAS-7821_remove_CSI_proxy branch 4 times, most recently from 9803501 to 236ef95 Compare February 18, 2025 09:15
@nikhilbarge nikhilbarge force-pushed the CNAS-7821_remove_CSI_proxy branch from 236ef95 to 216c998 Compare February 18, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants